Skip to content
This repository has been archived by the owner on Feb 11, 2019. It is now read-only.

Remove keys from redis once receipt is sent to vumi #15

Closed
wants to merge 5 commits into from
Closed

Remove keys from redis once receipt is sent to vumi #15

wants to merge 5 commits into from

Conversation

annasborysova
Copy link
Contributor

  • unnecessary information not stored
  • the 'read' receipt from WhatsApp gets blocked

@annasborysova
Copy link
Contributor Author

@hodgestar Ready for review

@annasborysova
Copy link
Contributor Author

@hodgestar Ready for review

hodgestar
hodgestar reviewed Jul 9, 2015
View reviewed changes
vxyowsup/whatsapp.py
# would be nice to remove to prevent sending delivery report for both delivered and 'read'
if vumi_id:
yield self.publish_delivery_report(user_message_id=vumi_id, delivery_status='delivered')
self.redis.delete(whatsapp_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a yield here.

@hodgestar
Copy link
Contributor

👍

@annasborysova annasborysova deleted the feature/issue-15-remove-keys-from-redis-test-redis branch July 9, 2015 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@annasborysova @hodgestar