This repository has been archived by the owner on Feb 11, 2019. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
annasborysova
commented
Jul 10, 2015
annasborysova
commented
- write failing tests
- make them pass
| self.assertEqual(node1.getChild('body'), node2.getChild('body')) | ||
| #xml1 = node1.toString().replace(node1["id"], id_stub) | ||
| #xml2 = node2.toString().replace(node2["id"], id_stub) | ||
| #self.assertEqual(xml1, xml2) |
There was a problem hiding this comment.
Could you explain why these changes were necessary?
There was a problem hiding this comment.
@hodgestar The xml string had things like "[ENCODED DATA]" or something.
There was a problem hiding this comment.
The cause of the [ENCODED DATA] is one of the darker corners of Python 2. In Python 2 once can do u"a" + "b" and the result is roughly the same as u"a" + b.decode(sys.getdefaultencoding()). This means that if we pass any unicode to yowsup, it unexpectedly causes yowsup to internally convert some of its byte strings into unicode strings (which surprises yowsup and results in the [ENCODED DATA] string in the XML).
|
Left one question, otherwise looks awesome. Many woots. |
…ed by suddenly discovering that some of its byte strings have become unicode.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.