Update travis to latest implementation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarzban
force-pushed
the
feature/issue-3-Update-travis-to-latest-implementation
branch
from
af43d28
to
affb59f
Compare
smarzban
force-pushed
the
feature/issue-3-Update-travis-to-latest-implementation
branch
from
f323e10
to
ae6594a
Compare
smarzban
force-pushed
the
feature/issue-3-Update-travis-to-latest-implementation
branch
from
ae6594a
to
33c0c77
Compare
JayH5
approved these changes
May 16, 2018
.travis.yml
Outdated
| - TEST=testapp_lint | ||
| - TEST=build | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
I would put this section at the bottom of the file to make things a little more readable.
.travis.yml
Outdated
| deploy: | ||
| provider: pypi | ||
| distributions: sdist bdist_wheel | ||
| user: Praekelt.org |
.travis.yml
Outdated
|
|
||
| jobs: | ||
| include: | ||
| - stage: deploy |
There was a problem hiding this comment.
I kind of prefer the name "release" since nothing is actually being deployed. But your project, your choice 😛
Also, if you add the if: tag IS present option then the stage won't be run at all if there isn't a tag which should save a bit of build time.
.travis.yml
Outdated
| env: [] | ||
| before_install: [] | ||
| install: [] | ||
| script: 'true' |
There was a problem hiding this comment.
Just script: skip might be a tiny bit quicker.
| @@ -0,0 +1,24 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
A better solution to this is probably to use tox.. But this script is fine too.
|
@JayH5 thanks for the feedback 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.