This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
Added coveralls #15
Merged
Added coveralls #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think merge this branch before #14 so that the PRs are clearer |
nathanbegbie
suggested changes
Jul 25, 2018
requirements.txt
Outdated
| constantly==15.1.0 | ||
| coverage==4.5.1 | ||
| coveralls==1.3.0 |
There was a problem hiding this comment.
It looks like in other projects, because coveralls is something we only use with Travis, we install it as part of the Travis set up - https://github.com/praekelt/molo/blob/develop/.travis.yml#L55
requirements.txt
Outdated
| daphne==2.2.0 | ||
| Django==2.0.6 | ||
| django-environ==0.4.5 |
There was a problem hiding this comment.
There seem to be some additions which are not part of this PR
There was a problem hiding this comment.
This came with the pip3 freeze command which I had forgotten to do before the last pull request.
nathanbegbie
approved these changes
Jul 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.