Make sending events to Jembi optional #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudigiesler
changed the title
KaitCrawford
reviewed
Nov 1, 2019
| ) | ||
|
|
||
| self.assertEqual(response.status_code, 200) | ||
| self.assertEqual(len(responses.calls), 1) |
There was a problem hiding this comment.
What is the call being made here?
There was a problem hiding this comment.
It's the call to Junebug, so probably not the best test to pick, but you can see the previous test asserts 2 calls, and this one asserts one
rudigiesler
deleted the
feature/PANIC-1-allow-disabling-of-sending-to-openhim
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has 2 parts.
First, we need to have a flag that we can set to stop sending events.
Second, we need a command we can run to resend any events that weren't sent