Feature/mcmr 152 add channel from rp contact to registration #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…act-to-registration
…ation' of github.com:praekeltfoundation/ndoh-hub into feature/MCMR-152-add-channel-from-rp-contact-to-registration
rudigiesler
reviewed
Apr 20, 2020
| @@ -164,7 +164,7 @@ def string_field(field, value): | |||
| VALUES %s | |||
| ON CONFLICT DO NOTHING | |||
| """, | |||
| ((contact_id, f"whatsapp:{wa}", wa, None, "whatsapp", ORG, 50, None, None),), | |||
| ((contact_id, f"whatsapp:{wa}", wa, None, "whatsapp", 1, 50, None, None),), | |||
There was a problem hiding this comment.
I think this change is unrelated, and something we want to keep. Try merging in develop into this branch, and see if that fixes it.
There was a problem hiding this comment.
okay, pulled the develop version. But there is a flake8 error with that line being too long so I'll push those changes
rudigiesler
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add the contact field to missing registrations