Support secrets

[felixb]

This allows to set up framework authentication.

[felixb]

I just rebased this PR on top of your develop branch. I guess it's easier to merge to review.
I worked in all your comments (w/o the require => File[..]. puppet is doing it's magic to auto-require)

[JayH5]

Ok.. I've thought about this a bit and can we maybe do:

$mesos_auth_principal   = undef,
$mesos_auth_secret      = undef,
$mesos_auth_secret_file = '/etc/marathon/.secret',

And then:

if ($mesos_auth_principal != undef) and ($mesos_auth_secret != undef) {
  $secret_options = {
    'mesos_authentication_principal'   => $mesos_auth_principal,
    'mesos_authentication_secret_file' => $mesos_auth_secret_file,
  }
} else { ...

Sorry for chopping and changing... $mesos_authentication_secret_file seems a bit long and also the secret is not much good without a principal.

Does this API sound good to you?

[JayH5]

Can you explain to me what you mean by "puppet is doing it's magic to auto-require".. As far as I can see the require is required although things might work "by accident".

[felixb]

Setting all auth options as param is fine. It's a bit tricky to get the overload logic.

Autorequires: If Puppet is managing the user or group that owns a file, the file resource will autorequire them. If Puppet is managing any parent directories of a file, the file resource will autorequire them.

Source: https://docs.puppetlabs.com/references/latest/type.html#file

[JayH5]

Ah thanks. Learn something new every day about Puppet :/

[JayH5]

Indentation of the = a bit messed up here since the parameter names got shorter.

[felixb]

I just rebased on current develop and fixed the indenting.

[JayH5]

Thanks for your work.

I think we should simplify the Mesos authentication logic and just either completely manage the auth principal/secret or not at all. See this diff: https://gist.github.com/JayH5/57f236f74d917442db2b

[felixb]

Sounds good to me. I'll merge your git and update the tests.

[JayH5]

lgtm. Can you please add a test where one of the principal/secret is not set and the secrets file and properties are not set?

[felixb]

these?

[JayH5]

Perfect :) Thank you.

[JayH5]

@felixb: Finally got around to releasing version 0.3.0 with your changes 😄