This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Adding -r flag to automatically clone and test remote go modules, along with functionality to test the Scan cmd #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made some minor changes (variable casing) when merging for consistency across the codebase, but I know we're all over the place with conventions in the repo. |
isp1r0
suggested changes
Aug 24, 2021
There was a problem hiding this comment.
- Functionality works great assuming repo does not yet exist
- Changes requested to error handling
- Running 'go test -v' in /cmd directory throws errors:
ianspiro@Ians-MacBook-Pro cmd % go test -v
=== RUN TestScanCommand
Current dir is: /Users/ianspiro/Documents/sandbox/chariot-2021/gokart/cmd=== RUN TestScanCommand/scan
=== RUN TestScanCommand/scan_-r_github.com/Contrast-Security-OSS/go-test-bench
scan_test.go:49: Failed! Expected: GoKart found 8 potentially vulnerable functions
Got: CRASH! GoKart didn't find any files to scan! Make sure the usage is correct to get GoKart back on track.
=== RUN TestScanCommand/scan_-r_github.com/praetorian-inc/gokart
scan_test.go:49: Failed! Expected: GoKart found 0 potentially vulnerable functions
Got: CRASH! GoKart didn't find any files to scan! Make sure the usage is correct to get GoKart back on track.
=== RUN TestScanCommand/scan_--help
--- FAIL: TestScanCommand (1.81s)
--- PASS: TestScanCommand/scan (0.44s)
--- FAIL: TestScanCommand/scan_-r_github.com/Contrast-Security-OSS/go-test-bench (0.74s)
--- FAIL: TestScanCommand/scan_-r_github.com/praetorian-inc/gokart (0.62s)
--- PASS: TestScanCommand/scan_--help (0.00s)
FAIL
exit status 1
FAIL github.com/praetorian-inc/gokart/cmd 2.592s```
- Deletion of repo does not currently happen for remote repos Suggest use of deferred call to CleanupModule
This was referenced Aug 24, 2021
…ote repo, adding verbosity to git failure
isp1r0
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
Outstanding @bpsizemore! This, combined with the -o,--output flag that @michaelweber added makes the usage completely frictionless 🏆
| // If we're given a target path, we do some slight changes to make sure that | ||
| // gokart will behave as expected. Specifically we turn the path into an absolute | ||
| // path, and then we append /... to the end to make sure the package loading is recursive. | ||
| // Finally we update the current working directory to the target | ||
| // In order to not cause issues we set the working directory back after we are done scanning. |
isp1r0
approved these changes
Aug 27, 2021
dwisiswant0
reviewed
Aug 29, 2021
| } | ||
| err = util.CloneModule(modDirName, "https://"+goModName) | ||
| if err != nil { | ||
| log.Fatal("GoKart was unable to get the new racetrack. Ensure track repository is open to the public or that your access tokens are configured correctly for Private ones.") |
There was a problem hiding this comment.
It said your access tokens are configured correctly for Private ones, but how do I define those things?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new flag
-ror--remoteModulewhich allows you to specify a remote module for analysis.Also added a new file gokart/cmd/scan_test.go which implements some very basic tests for the scan functionality. This should serve as a solid foundation as we add more features and modify the ability/way we specify modules to scan.