Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~R is deprecated #476

Merged
merged 5 commits into from
Jan 18, 2024
Merged

~R is deprecated #476

merged 5 commits into from
Jan 18, 2024

Conversation

bradhanks
Copy link
Contributor

No description provided.

@RobertDober
Copy link
Collaborator

Ty for your PR, as you can see this does not seem to work

@bradhanks
Copy link
Contributor Author

we are back in business. :)

I really enjoyed your course, btw. It was excellent advice to physically follow along and type everything out as the lessons progressed. I've actually continued that with doing some exercises with pen and paper to see if I really know it or if I'm just being prompted.

@RobertDober
Copy link
Collaborator

What course are you talking about?

I need to reflect a little bit about all the changes, you might not know that I have stepped down as a maintainer of Earmark so I's rather not spend too much time with it.

We should definitely take care of the deprecation warning, but the rest?

@RobertDober
Copy link
Collaborator

BTW would you be interested to maintain Earmark?

@bradhanks
Copy link
Contributor Author

bradhanks commented Jan 10, 2024

I don't really know I'm qualified but in theory I'm not opposed to it. Just in the sense that hypothetically if someone wanted to make some kind of feature change I wouldn't know how to proceed.

@RobertDober
Copy link
Collaborator

Hmm most feature changes would probably go to the parser of which I still (try to) take care and new features concering the transformation into html I have not seen for quite some time but I do not want to talk you into it ;)

@bradhanks
Copy link
Contributor Author

Hmm most feature changes would probably go to the parser of which I still (try to) take care and new features concering the transformation into html I have not seen for quite some time but I do not want to talk you into it ;)

No I'm happy to help as long as you know I'm probably going to be hesistant to be involved in anything that might break something. I have no problem manning the desk :)

@RobertDober
Copy link
Collaborator

Then I suggest the following:

  • I will ask Dave to give you full commit rights
  • I will of course help if I can and maybe do releases for now but that is up to Dave and you
    what do you think?

@amit-chaudhari1
Copy link
Collaborator

Sorry for barging in on the conversation,

@RobertDober I'd also like to be considered for being a maintainer.
if @bradhanks and @RobertDober allow me to take over and do not have any plans about where we should take this forward,
I'm describing my plans here.

I've picked up Elixir for about 10 months now gotten comfortable around the ecosystem, and I think it is my time to give back to this community.

If @bradhanks is okay with it. Could you please consider me for maintaining this library?

@bradhanks
Copy link
Contributor Author

Then I suggest the following:

  • I will ask Dave to give you full commit rights
  • I will of course help if I can and maybe do releases for now but that is up to Dave and you
    what do you think?

Sign me up :)

@bradhanks
Copy link
Contributor Author

What course are you talking about?

I need to reflect a little bit about all the changes, you might not know that I have stepped down as a maintainer of Earmark so I's rather not spend too much time with it.

We should definitely take care of the deprecation warning, but the rest?

Sorry I'm really green. Dave has a course. I didn't even look at the username. I just assumed it was him because it is in a repo named after him.

@amit-chaudhari1
Copy link
Collaborator

Looks Good.

There's

  • Readability refactors.
  • map_join refactors
  • ~R deprecation refactor

Ref: ~R is deprecated in favour of ~r

[Kernel] ~R/.../ is deprecated in favor of ~r/.../. This is because ~R/.../ still allowed escape codes, which did not fit the definition of uppercase sigils

@amit-chaudhari1 amit-chaudhari1 merged commit 8c0c9ae into pragdave:master Jan 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants