Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete: delete volumes attached to a non-existent instance #7

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

praiskup
Copy link
Owner

This sometimes happens, due to inconsistency in the OpenStack database. Fortunately, typically the volume is removable even though it appears attached.

@praiskup
Copy link
Owner Author

@FrostyX would you mind taking a quick look even here? This will let Resalloc remove even the wrongly attached volumes.

This sometimes happens, due to inconsistency in the OpenStack database.
Fortunately, typically the volume is removable even though it appears
attached.

Fixes: #7
@praiskup praiskup force-pushed the volume-on-non-existing-instance branch from ff99800 to f60454f Compare September 20, 2022 12:11
@FrostyX
Copy link
Collaborator

FrostyX commented Sep 20, 2022

The gather_tasks function is starting to get lengthy, when adding something in the future, we should separate some of its code into smaller functions.

But this PR looks good to me.

@praiskup praiskup merged commit 3800bdd into main Sep 20, 2022
@praiskup praiskup deleted the volume-on-non-existing-instance branch November 23, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants