Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_transform function will fail on cases where there is a flip in the coordinate lists. #2

Closed
prajwel opened this issue May 9, 2023 · 2 comments
Closed

find_transform function will fail on cases where there is a flip in the coordinate lists. #2

prajwel opened this issue May 9, 2023 · 2 comments

Comments

@prajwel
Copy link
Owner

prajwel commented May 9, 2023 •
edited
Loading

find_transform function with ttype='similarity' or ttype='euclidean' will fail or provide unexpected results in cases where there is a flip in the coordinate lists. This is due to the Umeyama algorithm for estimating similarity and Euclidean transformations. It will avoid any solution that requires reflection.
@prajwel prajwel changed the title find_transform function seems to fail on cases where there is a flip in the coordinate lists. find_transform function will fail on cases where there is a flip in the coordinate lists. May 25, 2023
prajwel added a commit that referenced this issue May 28, 2023
@prajwel
Addresses #2.
96869a6
@prajwel
Copy link
Owner Author

prajwel commented May 28, 2023

Added this under caveat section.

@prajwel prajwel closed this as completed May 28, 2023
@prajwel prajwel reopened this Jun 3, 2023
@prajwel
Copy link
Owner Author

prajwel commented Jun 3, 2023

Replacing Umeyama's method with Arun and Horn's should solve this problem.

@prajwel prajwel closed this as completed in 3326b12 Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prajwel