Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mDNS update to main loop for ESP8266 #253

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Add mDNS update to main loop for ESP8266 #253

merged 1 commit into from
Apr 21, 2022

Conversation

shmick
Copy link
Contributor

@shmick shmick commented Apr 21, 2022

On ESP8266 it needs MDNS.update() to run in the main loop

@shmick shmick changed the title Add mDNS update to main loop Add mDNS update to main loop for ESP8266 Apr 21, 2022
@prampec
Copy link
Owner

prampec commented Apr 21, 2022

As far as I see, the update must be called as frequently as possible in ESP8266.
https://github.com/esp8266/Arduino/blob/master/libraries/ESP8266mDNS/src/LEAmDNS.h

So it should be placed inside the doLoop() method. (Must be tested before I approve!)

@shmick
Copy link
Contributor Author

shmick commented Apr 21, 2022

So it should be placed inside the doLoop() method. (Must be tested before I approve!)

My code update does place it inside doLoop() inside of the else if (this->_state == OnLine statement

I can confirm that it's working from my own local testing. Always best to have others test as well.

@prampec prampec merged commit 44b79bf into prampec:master Apr 21, 2022
@prampec
Copy link
Owner

prampec commented Apr 21, 2022

Sorry, I have missed something.

@prampec
Copy link
Owner

prampec commented Apr 21, 2022

Thank you for your contribution.

@shmick shmick deleted the mdns_ESP8266 branch April 21, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants