Regress fixes for PG13 - PG16 and simplification #251
Conversation
- Just use libgdal-dev from main repo, its 3.4 still same as ubuntugis - Allow read of source folder
- Remove all preinstalled postgresql, PG14 was installed in all of them Which was causing issues for PG13 - Force all postgresql dependencies to come from apt.postgresql.org - Use pg_lsclusters to confirm what are running, mostly for debugging in future - Put back PG16 in testing loop
|
Okay I managed to get them all working. I'm not sure if for whatever reason the GHA image just comes with PostgreSQL 14 installed or if it was being pulled in by GDAL. I also changed the routine back to using pg_ctlcluster instead of your make shift pg_ctl command. I think that might have been causing issues with PG16, some extra thing you might have needed to add. |
robe2
changed the title
|
I forgot to mention I turned back on PG16 since it's now working. |
|
OK, I will take this and probably trim it a little as I figured out the pg13 problem myself yesterday. GHA does ship with pg14, but if you are clever you can leave it in place and install the other versions you want and force paths to make it work. This is nice as it removes the need to correctly remove pg14 and thus the need to peg the runner version. (It's also fewer lines :) |
This mostly sets the permission of the folders so PG14 and PG15 regress cleanly.
I also got rid of ubuntugis because the version shipped with latest ubuntu is 3.4.1 (not too far from ubuntugis 3.4.3). I'm mostly concerned about other things ubuntugis might bring in. You can revert if you want.
The issue with PG13 is puzzling. I tried wiping out all remnants of PostgreSQL and even setting priority of PostgreSQL install.
It seems to be actually creating a postgresql 14 folder to install things in. So this might be a bug in apt.postgresql.org instead. I'll test later on ubuntu latest 13 to see if I get the same odd behavior.