Sourcery Starbot ⭐ refactored pranathivemuri/vessels-ct-radius #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourcery-ai-bot
commented
Feb 5, 2023
Comment on lines
-218
to
+220
| raise ValueError("Given radius '{}' does not fit in cube edge length {}" | ||
| .format(radius, cube_edge)) | ||
| raise ValueError( | ||
| f"Given radius '{radius}' does not fit in cube edge length {cube_edge}" | ||
| ) |
There was a problem hiding this comment.
Function vessel_diagonal refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
Comment on lines
-335
to
+338
| assert similarity >= accuracy, \ | ||
| "Binmask similarity {} < target accuracy {}".format(similarity, accuracy) | ||
| assert ( | ||
| similarity >= accuracy | ||
| ), f"Binmask similarity {similarity} < target accuracy {accuracy}" |
There was a problem hiding this comment.
Function assert_binmask_similar refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| boundary_image = binary_image - erode_image | ||
| return boundary_image | ||
| return binary_image - erode_image |
There was a problem hiding this comment.
Function get_boundaries_of_image refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-71
to
+70
| dict_nodes_radius = {item: eucledian_radius_image[item] for item in list_nzi} | ||
| return dict_nodes_radius | ||
| return {item: eucledian_radius_image[item] for item in list_nzi} |
There was a problem hiding this comment.
Function get_radius_2d refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-119
to
+117
| dict_nodes_radius.update(new_d) | ||
| dict_nodes_radius |= new_d |
There was a problem hiding this comment.
Function get_radius_slicewise refactored with the following changes:
- Merge dictionary updates via the union operator (
dict-assign-update-to-union)
Comment on lines
-137
to
+138
| max_dict = {} | ||
| for key, val in list_of_dicts[0].items(): | ||
| max_dict[key] = max(list_of_dicts[i][key] for i in range(len(list_of_dicts))) | ||
| return max_dict | ||
| return { | ||
| key: max(list_of_dicts[i][key] for i in range(len(list_of_dicts))) | ||
| for key, val in list_of_dicts[0].items() | ||
| } |
There was a problem hiding this comment.
Function get_max_dict refactored with the following changes:
- Convert for loop into dictionary comprehension (
dict-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-177
to
+175
| dict_nodes_radius = get_max_dict(d) | ||
| return dict_nodes_radius | ||
| return get_max_dict(d) |
There was a problem hiding this comment.
Function get_radius_3d refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: