Improve recycler view frame

Improve progress state changes. Add end offset for swipe refresh layout.
pranavpandey · Jun 10, 2021 · 25e82b7 · 25e82b7
1 parent 7d85fb8
commit 25e82b7
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 16 deletions.
diff --git a/.../java/com/pranavpandey/android/dynamic/support/recyclerview/DynamicRecyclerViewFrame.java b/.../java/com/pranavpandey/android/dynamic/support/recyclerview/DynamicRecyclerViewFrame.java
@@ -293,15 +293,21 @@ public void setOnRefreshListener(
      * @param animate {@code true} to animate the changes.
      */
     public void showProgress(boolean animate) {
-        if (mProgressBar != null) {
-            if (animate) {
-                TransitionManager.beginDelayedTransition(this);
-            }
-
-            Dynamic.setVisibility(mProgressBar, VISIBLE);
-            Dynamic.setVisibility(mRecyclerView, GONE);
-            mProgressBar.show();
+        if (mProgressBar == null) {
+            return;
         }
+
+        post(new Runnable() {
+            @Override
+            public void run() {
+                if (animate) {
+                    TransitionManager.beginDelayedTransition(DynamicRecyclerViewFrame.this);
+                }
+
+                Dynamic.setVisibility(mProgressBar, VISIBLE);
+                Dynamic.setVisibility(mRecyclerView, GONE);
+            }
+        });
     }
 
     /**
@@ -319,15 +325,21 @@ public void showProgress() {
      * @param animate {@code true} to animate the changes.
      */
     public void hideProgress(boolean animate) {
-        if (mProgressBar != null) {
-            if (animate) {
-                TransitionManager.beginDelayedTransition(this);
-            }
-
-            Dynamic.setVisibility(mProgressBar, GONE);
-            Dynamic.setVisibility(mRecyclerView, VISIBLE);
-            mProgressBar.hide();
+        if (mProgressBar == null) {
+            return;
         }
+
+        post(new Runnable() {
+            @Override
+            public void run() {
+                if (animate) {
+                    TransitionManager.beginDelayedTransition(DynamicRecyclerViewFrame.this);
+                }
+
+                Dynamic.setVisibility(mProgressBar, GONE);
+                Dynamic.setVisibility(mRecyclerView, VISIBLE);
+            }
+        });
     }
 
     /**

diff --git a/.../main/java/com/pranavpandey/android/dynamic/support/widget/DynamicSwipeRefreshLayout.java b/.../main/java/com/pranavpandey/android/dynamic/support/widget/DynamicSwipeRefreshLayout.java
@@ -122,6 +122,9 @@ public void loadFromAttributes(@Nullable AttributeSet attrs) {
 
     @Override
     public void initialize() {
+        setProgressViewEndTarget(true, getResources().getDimensionPixelOffset(
+                R.dimen.ads_margin_swipe_refresh_layout));
+
         if (mColorType != Theme.ColorType.NONE
                 && mColorType != Theme.ColorType.CUSTOM) {
             mColor = DynamicTheme.getInstance().resolveColorType(mColorType);

diff --git a/dynamic-support/src/main/res/values/dimens.xml b/dynamic-support/src/main/res/values/dimens.xml
@@ -52,6 +52,7 @@
     <dimen name="ads_margin_fab_compat_mini_bottom">@dimen/ads_margin_small</dimen>
     <dimen name="ads_margin_divider">1dp</dimen>
     <dimen name="ads_margin_divider_large">@dimen/ads_margin_extra_tiny</dimen>
+    <dimen name="ads_margin_swipe_refresh_layout">@dimen/ads_margin_huge</dimen>
     <dimen name="ads_margin_preference_value">@dimen/ads_margin_normal</dimen>
     <dimen name="ads_margin_preference_icon_end">@dimen/ads_margin_normal</dimen>
     <dimen name="ads_margin_preference_icon_end_big">@dimen/ads_margin_large_big</dimen>