Replace hard coded # with string resource

pranavpandey · Jul 5, 2023 · 98dbdda · 98dbdda
1 parent 564b703
commit 98dbdda
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/dynamic-support/src/main/res/layout-w600dp/ads_color_picker_custom.xml b/dynamic-support/src/main/res/layout-w600dp/ads_color_picker_custom.xml
@@ -57,8 +57,7 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:textSize="@dimen/ads_picker_font_size_medium"
-                    android:text="#"
-                    tools:ignore="HardcodedText,TextViewEdits" />
+                    android:text="@string/ads_unit_hash" />
 
                 <com.pranavpandey.android.dynamic.support.widget.DynamicEditText
                     android:id="@+id/ads_color_picker_edit"

diff --git a/dynamic-support/src/main/res/layout/ads_color_picker_custom.xml b/dynamic-support/src/main/res/layout/ads_color_picker_custom.xml
@@ -71,8 +71,7 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:textSize="@dimen/ads_picker_font_size_medium"
-                android:text="#"
-                tools:ignore="HardcodedText,TextViewEdits" />
+                android:text="@string/ads_unit_hash" />
 
             <com.pranavpandey.android.dynamic.support.widget.DynamicEditText
                 android:id="@+id/ads_color_picker_edit"

diff --git a/dynamic-support/src/main/res/values/donottranslate-strings.xml b/dynamic-support/src/main/res/values/donottranslate-strings.xml
@@ -36,6 +36,7 @@
     <string name="ads_cancel">@android:string/cancel</string>
     <string name="ads_unit_percent">%</string>
     <string name="ads_unit_pixel">px</string>
+    <string name="ads_unit_hash">#</string>
 
     <!-- Locales -->
     <string name="ads_locale_system">@string/ads_language_system</string>