Improve tutorial background

Set root background instead of the window to make shared element transition smoother.
pranavpandey · Aug 30, 2022 · b02d0e2 · b02d0e2
1 parent 7058b0c
commit b02d0e2
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 3 deletions.
diff --git a/dynamic-support/src/main/java/com/pranavpandey/android/dynamic/support/Dynamic.java b/dynamic-support/src/main/java/com/pranavpandey/android/dynamic/support/Dynamic.java
@@ -22,6 +22,7 @@
 import android.content.Intent;
 import android.graphics.Bitmap;
 import android.graphics.Color;
+import android.graphics.drawable.ColorDrawable;
 import android.graphics.drawable.Drawable;
 import android.graphics.drawable.Icon;
 import android.graphics.drawable.LayerDrawable;
@@ -30,6 +31,7 @@
 import android.text.TextUtils;
 import android.text.TextWatcher;
 import android.view.View;
+import android.view.Window;
 import android.widget.Button;
 import android.widget.EditText;
 import android.widget.ImageView;
@@ -1665,6 +1667,25 @@ public static void setElevation(@Nullable View view, float elevation) {
         }
     }
 
+    /**
+     * Sets the background for the window or root view.
+     *
+     * @param dynamic The dynamic object to be used.
+     * @param color The color to be set.
+     * @param <T> The type of the dynamic object.
+     *
+     * @see Window#setBackgroundDrawable(Drawable)
+     * @see View#setBackgroundDrawable(Drawable)
+     * @see #withThemeOpacity(Drawable)
+     */
+    public static <T> void setRootBackground(@Nullable T dynamic, @ColorInt int color) {
+        if (dynamic instanceof Window) {
+            ((Window) dynamic).setBackgroundDrawable(withThemeOpacity(new ColorDrawable(color)));
+        } else if (dynamic instanceof View) {
+            ((View) dynamic).setBackgroundDrawable(withThemeOpacity(new ColorDrawable(color)));
+        }
+    }
+
     /**
      * Set background drawable for the view.
      *

diff --git a/...rc/main/java/com/pranavpandey/android/dynamic/support/activity/DynamicSystemActivity.java b/...rc/main/java/com/pranavpandey/android/dynamic/support/activity/DynamicSystemActivity.java
@@ -27,7 +27,6 @@
 import android.content.pm.ActivityInfo;
 import android.content.res.Configuration;
 import android.graphics.Color;
-import android.graphics.drawable.ColorDrawable;
 import android.os.Build;
 import android.os.Bundle;
 import android.transition.Fade;
@@ -1002,10 +1001,26 @@ protected void navigationBarThemeChange() {
      * Sets the window background color.
      *
      * @param color The window background color to be set.
+     *
+     * @see #getWindow()
+     * @see Dynamic#setRootBackground(Object, int)
      */
     public void setWindowBackground(@ColorInt int color) {
         this.mBackgroundColor = color;
-        getWindow().setBackgroundDrawable(new ColorDrawable(Dynamic.withThemeOpacity(color)));
+
+        Dynamic.setRootBackground(getWindow(), color);
+    }
+
+    /**
+     * Sets the root background color.
+     *
+     * @param color The root background color to be set.
+     *
+     * @see R.id#ads_activity_root
+     * @see Dynamic#setRootBackground(Object, int)
+     */
+    public void setRootBackground(@ColorInt int color) {
+        Dynamic.setRootBackground(findViewById(R.id.ads_activity_root), color);
     }
 
     /**

diff --git a/...a/com/pranavpandey/android/dynamic/support/tutorial/activity/DynamicTutorialActivity.java b/...a/com/pranavpandey/android/dynamic/support/tutorial/activity/DynamicTutorialActivity.java
@@ -615,7 +615,7 @@ protected void onSetColor(int position, @ColorInt int color, @ColorInt int tintC
             }
         }
 
-        setWindowBackground(color);
+        setRootBackground(color);
         setStatusBarColor(systemUIColor);
         setNavigationBarColor(systemUIColor);
         updateTaskDescription(color);