Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to tests of nickTracker.py #254

Closed
prasadtalasila opened this issue Feb 12, 2018 · 2 comments
Closed

Improvements to tests of nickTracker.py #254

prasadtalasila opened this issue Feb 12, 2018 · 2 comments
Assignees
@bhuvangupta008
Labels
bug
Projects
Testing

Comments

@prasadtalasila
Copy link
Owner

prasadtalasila commented Feb 12, 2018 •
edited

The nickTracker module exists at three places:

There are three lines that are not covered by unit tests in these files. We need to add tests to cover these lines.
@prasadtalasila prasadtalasila added this to TODO in Testing via automation Feb 12, 2018
@prasadtalasila prasadtalasila moved this from TODO to In Progress in Testing Feb 12, 2018
@prasadtalasila prasadtalasila moved this from In Progress to TODO in Testing Feb 12, 2018
@prasadtalasila prasadtalasila moved this from TODO to In Progress in Testing Feb 14, 2018
@bhuvangupta008
Copy link
Contributor

  • Modified log files for lib/nickTracker.py.
  • For other two, since there are no different channels, we need to refactor the code to remove these uncovered redundant lines.

This was referenced Feb 17, 2018
Merged
Merged
@bhuvangupta008 bhuvangupta008 moved this from In Progress to Done in Testing Feb 18, 2018
@prasadtalasila
Copy link
Owner Author

Issue solved via PR #265 and #266.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhuvangupta008 bhuvangupta008

Labels
bug
Projects
Testing
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@prasadtalasila @bhuvangupta008 @Kausam