Removes some redundant code from nicktracker for slack and scummvm

[bhuvangupta008]

What? Why?

Fix #254 . (Add Reference to the issue if any)

Changes proposed in this pull request:

• a Removed redundant code for multi channel analysis for slack and scummvm
• b Modified nicktracker test file for both slack and scummvm

Notify reviewers

@kaushik-rohit
@prasadtalasila

[codecov]

Codecov Report

Merging #266 into dev will decrease coverage by 0.19%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##              dev     #266     +/-   ##
=========================================
- Coverage   91.44%   91.25%   -0.2%     
=========================================
  Files          15       15             
  Lines        2362     2241    -121     
=========================================
- Hits         2160     2045    -115     
+ Misses        202      196      -6

Impacted Files	Coverage Δ
lib/slack/nickTracker.py	100% <100%> (+2.75%)	⬆️
lib/scummvm/nickTracker.py	100% <100%> (+2.75%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bef98a...ea73e54. Read the comment docs.

[coveralls]

Coverage increased (+1.8%) to 35.118% when pulling ea73e54 on bhuvangupta008:nicktracker into 2bef98a on prasadtalasila:dev.

[prasadtalasila]

@kaushik-rohit please review this PR.

[kaushik-rohit]

@bhuvangupta008 The PR looks good to me. It is true that don't need to create a dictionary with nicks and channels since slack and scummvm analysis is isolated. Since this doesn't break anything, it seems that we were anyway not using it anywhere. Just one suggestion, since it also modifies the test, can you update the commit message to reflect that.

[prasadtalasila]

@kaushik-rohit and @bhuvangupta008 I updated the commit message during the squash and merge. No need to amend the commit message.