Adding Input Parser to Alpha Branch

[bgargi]

• Motivation : Porting the input parser along with unit tests to the alpha branch ( Issue #85)

• Integration test yet to be added

[coveralls]

Coverage increased (+1.3%) to 96.786% when pulling a512e23 on bgargi:ts-v1.0-alpha into 5f98d03 on prasadtalasila:ts-v1.0-alpha.

[codecov]

Codecov Report

Merging #127 into ts-v1.0-alpha will increase coverage by 1.29%.
The diff coverage is 100%.

@@                Coverage Diff                @@
##           ts-v1.0-alpha     #127      +/-   ##
=================================================
+ Coverage          95.48%   96.78%   +1.29%     
=================================================
  Files                 11       11              
  Lines                266      280      +14     
=================================================
+ Hits                 254      271      +17     
+ Misses                12        9       -3

Flag	Coverage Δ
#integration	35.71% <0%> (-29.7%)	⬇️
#unit	62.14% <100%> (+6.87%)	⬆️

Impacted Files	Coverage Δ
apps/network/lib/network/station/station.ex	100% <ø> (ø)	⬆️
apps/network/lib/network/station/FSM.ex	98.68% <ø> (ø)	⬆️
apps/network/lib/network/station/registry.ex	100% <100%> (+2.56%)	⬆️
apps/input_parser/lib/input_parser.ex	100% <100%> (ø)
apps/input_parser/lib/input_parser/application.ex	0% <0%> (-100%)	⬇️
apps/api/lib/api/application.ex	100% <0%> (+100%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f98d03...a512e23. Read the comment docs.

[prasadtalasila]

Suggestions:

1. Add credo config and ignore specific false positives.
2. Migrate itinerary unit tests from network app to util app.
3. Upgrade exunit. Use setup and teardown features of unit tests for developing upcoming tests.
4. Remove the dummy utl.ex file.
5. Define behavior for input parser and update the input parser and its unit tests.

[prasadtalasila]

@bgargi
There is duplication of data in the PR. The following files exist in two locations.

 59,555 apps/input_parser/data/schedule.txt 
 59,555 data/schedule.txt 
 2,264 apps/input_parser/data/local_variables.txt 
 2,264 data/local_variables.txt 
 2,264 apps/input_parser/data/stations.txt 
 2,264 data/stations.txt 
 151 apps/input_parser/data/OMT.txt 
 151 data/OMT.txt 

Please keep the data in data/ directory at the top-level and remove the same from apps/input_parser/data. Do remember to update the references to files in the code base of input parser.

[prasadtalasila]

The code readability issues pointed out by credo are valid issues.

  Code Readability                                                              
┃ 
┃ [R] ↘ The alias `Util.Connection` is not alphabetically ordered among its 
┃       group.
┃       apps/util/test/unit/itinerary_test.exs:11:9 #(ItineraryTest)
┃ [R] ↘ The alias `Util.Connection` is not alphabetically ordered among its 
┃       group.
┃       apps/network/test/unit/collector_test.exs:11:9 #(CollectorTest)
┃ [R] ↘ The alias `Util.Connection` is not alphabetically ordered among its 
┃       group.
┃       apps/network/test/integration/station_stress_test.exs:10:9 #(StationStressTest)
┃ [R] ↘ The alias `Util.Connection` is not alphabetically ordered among its 
┃       group.
┃       apps/network/test/integration/station_processing_test.exs:13:9 #(StationProcessingTest)
┃ [R] ↘ The alias `Util.Connection` is not alphabetically ordered among its 
┃       group.
┃       apps/network/test/integration/station_correctness_test.exs:11:9 #(StationCorrectnessTest)
┃ [R] ↘ The alias `Util.Connection` is not alphabetically ordered among its 
┃       group.
┃       apps/network/test/integration/station_contract_test.exs:12:9 #(StationContractTest)
┃ [R] ↘ The alias `Util.Connection` is not alphabetically ordered among its 
┃       group.
┃       apps/network/test/integration/station_FSM_test.exs:12:9 #(StationFSMTest)

The logs are taken from travis build. Please rearrange the alias lines into correct alphabetical order.