New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Network Constructor #129
Conversation
""" | ||
use Application | ||
alias Station.QueryCollector, as: QueryCollector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that the query collector is something to be created by api outside of network. Hence, it is appropriate to move the query collector to util/lib and update the dependencies network module.
please remember to move the tests as well.
Codecov Report
@@ Coverage Diff @@
## ts-v1.0-alpha #129 +/- ##
================================================
- Coverage 96.78% 92.49% -4.3%
================================================
Files 11 12 +1
Lines 280 293 +13
================================================
Hits 271 271
- Misses 9 22 +13
Continue to review full report at Codecov.
|
Motivation : To add a network constructor module which interacts with the input parser and spawns a network of stations with the appropriate data.