Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Network Constructor #129

Closed
wants to merge 11 commits into from

Conversation

bgargi
Copy link
Collaborator

@bgargi bgargi commented Oct 18, 2018

Motivation : To add a network constructor module which interacts with the input parser and spawns a network of stations with the appropriate data.

  • Added in the file ./apps/network/lib/network.ex

"""
use Application
alias Station.QueryCollector, as: QueryCollector
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that the query collector is something to be created by api outside of network. Hence, it is appropriate to move the query collector to util/lib and update the dependencies network module.
please remember to move the tests as well.

@codecov
Copy link

codecov bot commented Oct 21, 2018

Codecov Report

Merging #129 into ts-v1.0-alpha will decrease coverage by 4.29%.
The diff coverage is 23.52%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ts-v1.0-alpha     #129     +/-   ##
================================================
- Coverage          96.78%   92.49%   -4.3%     
================================================
  Files                 11       12      +1     
  Lines                280      293     +13     
================================================
  Hits                 271      271             
- Misses                 9       22     +13
Flag Coverage Δ
#integration 34.12% <0%> (-1.59%) ⬇️
#unit 59.38% <23.52%> (-2.76%) ⬇️
Impacted Files Coverage Δ
apps/input_parser/lib/input_parser/application.ex 0% <ø> (ø) ⬆️
apps/network/lib/network.ex 0% <0%> (ø)
apps/input_parser/lib/input_parser.ex 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fa2449...0ba10b1. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.3%) to 92.491% when pulling 0ba10b1 on bgargi:ts-v1.0-alpha into 9fa2449 on prasadtalasila:ts-v1.0-alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants