Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to map keycode to a certain symbol for keybinds hint #1303

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

kRHYME7
Copy link
Collaborator

@kRHYME7 kRHYME7 commented Apr 13, 2024

Pull Request

Description

Just found out that keycodes do have a different variable than key
#1302 (comment)

As of the moment keycode mapping is not yet implemented
This MR gives as the ability to use 'code:n' or keycodes on our keybinds hint and can actually be converted to the prefered symbole.

e.g

keycode:61 is '?'

UPDATE:

Also added an option to map the keycode manually ( key codes are actually tied to some keyboard layout so would be better to map it manually https://www.toptal.com/developers/keycode/table )

image

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

image

(if appropriate)

Additional context

Add any other context about the problem here.

@kRHYME7 kRHYME7 marked this pull request as ready for review April 13, 2024 17:33
Copy link
Owner

@prasanthrangan prasanthrangan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, it works!

@prasanthrangan prasanthrangan merged commit ddfe7ac into main Apr 15, 2024
@kRHYME7 kRHYME7 deleted the keybindshint branch April 16, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants