Bug fix: Delete confirm dialog will work wrong aflter cancel. #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tton multiple times and canceling.
prasathmani
requested changes
Jan 18, 2023
tinyfilemanager.php
Outdated
| @@ -4008,6 +4008,9 @@ function confirmDailog(e, id = 0, title = "Action", content = "", action = null) | |||
| let tpl = $("#js-tpl-confirm").html(); | |||
| $(".modal.confirmDailog").remove(); | |||
| $('#wrapper').append(template(tpl,tplObj)); | |||
| $("#confirmDialog-"+tplObj.id).on('hidden.bs.modal', function() { | |||
There was a problem hiding this comment.
as we are using same selector on next line as well, better catch the selector.
const $confirmDailog = $("#confirmDialog-"+tplObj.id);
$confirmDailog.on('hidden.bs.modal', function() {..}
$confirmDailog.modal('show');
prasathmani
approved these changes
Jan 19, 2023
ner00
pushed a commit
to ner00/tinyfilemanager
that referenced
this pull request
May 7, 2023
…hmani#942) * Bug fix: Only delete first file/directory when clicking the delete button multiple times and canceling. * Add variable name for delete dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking and canceling the delete confirm dialog will cause the information when the last confirmation of deletion is the file/directory information of the first click on the delete button.
Example on Demo: