Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced array() with [] and added bengali language #994

Closed
wants to merge 2 commits into from
Closed

replaced array() with [] and added bengali language #994

wants to merge 2 commits into from

Conversation

joybiswas007
Copy link
Contributor

No description provided.

@divinity76
Copy link
Contributor

divinity76 commented Apr 10, 2023

some things wrong here:
1: using [] or array() is just a personal preference thing, and until the project has an official coding style guidelines, there's no reason to change the existing ones to one or the other.

2: your tinyfilemanager.php has been converted to DOS newlines somehow, every single newline has been replaced with crlf (\r\n) - there are many ways this could have happened, many text editors can do it, and even git can be configured to do it (eg git config --global core.eol=crlf ), but regardless of how it happened, it should be fixed before being considered for merging. can you try running

git config --global core.autocrlf true;
git stage tinyfilemanager.php;
git commit -m "crlf issue"
git push

and see what happens?

divinity76 added a commit to divinity76/tinyfilemanager that referenced this pull request Apr 10, 2023
prasathmani pushed a commit that referenced this pull request Apr 11, 2023
@joybiswas007
Copy link
Contributor Author

Thanks for heads up. I'll follow the steps that you provided and send pull request again. This time I'll just send the request for bengali language support.

@joybiswas007 joybiswas007 closed this by deleting the head repository Apr 11, 2023
ner00 pushed a commit to ner00/tinyfilemanager that referenced this pull request May 6, 2023
ner00 pushed a commit to ner00/tinyfilemanager that referenced this pull request May 6, 2023
ner00 pushed a commit to ner00/tinyfilemanager that referenced this pull request May 7, 2023
ner00 pushed a commit to ner00/tinyfilemanager that referenced this pull request May 7, 2023
ner00 pushed a commit to ner00/tinyfilemanager that referenced this pull request May 7, 2023
ner00 pushed a commit to ner00/tinyfilemanager that referenced this pull request May 7, 2023
ner00 pushed a commit to ner00/tinyfilemanager that referenced this pull request May 7, 2023
prasathmani added a commit that referenced this pull request May 7, 2023
* publish additional docker tags (#975)

* Update Romanian translations (#981)

* Update tinyfilemanager.php

* Prevent logout issue after page was cached (#1004)

Logout may not work otherwise, browser reloads cached page from disk instead of sending GET request ?logout=1 to server.

* tell git to always commit .php in unix-newlines (#1017)

so hopefully we don't get a repeat of #994 (comment)

* Check if posix_getpwuid/posix_getgrgid calls were successful (#1023)

* use stream_copy_to_stream (#1014)

* use stream_copy_to_stream

it's simpler, and should be faster.
For example, stream_copy_to_stream can use sendfile ( https://man7.org/linux/man-pages/man2/sendfile.2.html ) on operating systems supporting it, which is faster and use less RAM than fread()+fwrite() (because it avoids copying data to/from userland, doing the copy entirely in-kernel~)

* fix loop early return, and workaround bug

* use feof

ref #1016 (comment)

* added bengali translation (#1018)

* Fix upload of existing files (#1026)

* Fix typo. (#1028)

* login (Redirecting to Main domain of website instead of tfm.php) fix (#1031)

When logged in it takes to the website's main URL. For example, if I have tfm in www.example.com/tfm/index.php (index.php is tfm) then after logging in it redirects to www.example.com and then have to press back on the browser then it takes to www.example.com/tfm/index.php

* Add configurable path display modes for better privacy and clarity (#1034)

* Resize preview image and implement zoom in/out (#1036)

* Resize preview image and implement zoom in/out

* Remove redundant class name

---------

Co-authored-by: ssams <6338356+ssams@users.noreply.github.com>
Co-authored-by: Sergiu Bivol <sergiu@cip.md>
Co-authored-by: Prasath Mani <prasathmani@users.noreply.github.com>
Co-authored-by: divinity76 <divinity76@gmail.com>
Co-authored-by: Micha Ober <github@ober-mail.de>
Co-authored-by: Joy Biswas <74253956+joybiswas007@users.noreply.github.com>
Co-authored-by: Micha Ober <git@ober-mail.de>
Co-authored-by: Caleb Mazalevskis <maikuolan@gmail.com>
Co-authored-by: xololunatic <97784387+xololunatic@users.noreply.github.com>
Co-authored-by: DannyDaemonic <DannyDaemonic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants