New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary condition inside create_file_list #12

Open

PrashanthaTP opened this issue Aug 23, 2021 · 1 comment

Labels

Owner

PrashanthaTP commented Aug 23, 2021

Why check for length of FROM_DIR ,when we can assign the value in the first place

wav2mov/wav2mov/datasets/create_file_list.py

Lines 9 to 17 in 3061ed6

    
           FROM_DIR = '' 
        
           TO_DIR = '' 
        
           VIDEOS_PER_ACTOR = 30 
        
           if len(FROM_DIR)==0: 
        
               FROM_DIR = os.path.dirname(os.path.abspath(__file__)) 
        
               FROM_DIR = os.path.join(FROM_DIR,DATASET) 
        
               TO_DIR = FROM_DIR

PrashanthaTP added the codequality label

Owner Author

PrashanthaTP commented Aug 23, 2021

Yeayaah😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment