fix docs bug & reformat code

praswicaksono · Aug 13, 2015 · 2b106b9 · 2b106b9
1 parent bc1b9ab
commit 2b106b9
Show file tree

Hide file tree

Showing 13 changed files with 32 additions and 35 deletions.
diff --git a/src/Application.php b/src/Application.php
@@ -327,7 +327,7 @@ public function periodic($interval, callable $callback)
      */
     public function isServerExist()
     {
-        if (! $this->container->offsetExists('Server')) {
+        if (!$this->container->offsetExists('Server')) {
             throw new \RuntimeException('server must be set in container');
         }
 

diff --git a/src/Events/BeforeRouteEvent.php b/src/Events/BeforeRouteEvent.php
@@ -2,8 +2,8 @@
 
 namespace Vinnige\Events;
 
-use Symfony\Component\EventDispatcher\Event;
 use Psr\Http\Message\ServerRequestInterface;
+use Symfony\Component\EventDispatcher\Event;
 
 /**
  * Class BeforeRouteEvent

diff --git a/src/Lib/Container/LaravelContainer.php b/src/Lib/Container/LaravelContainer.php
@@ -26,7 +26,7 @@ public function __construct(Container $container)
 
     /**
      * @param array|string $abstract
-     * @param callable|\Closure|null $concrete
+     * @param string|\Closure|null $concrete
      */
     public function bind($abstract, $concrete = null)
     {
@@ -35,7 +35,7 @@ public function bind($abstract, $concrete = null)
 
     /**
      * @param array|string $abstract
-     * @param null $concrete
+     * @param string|\Closure|null $concrete
      */
     public function singleton($abstract, $concrete = null)
     {

diff --git a/src/Lib/Http/Exceptions/GoneHttpException.php b/src/Lib/Http/Exceptions/GoneHttpException.php
@@ -15,6 +15,6 @@ class GoneHttpException extends HttpException
      */
     public function __construct($message = '', $code = 0, \Exception $previous = null)
     {
-        parent::__construct(410, $message, $code, $previous);
+        parent::__construct(410, $message, [], $code, $previous);
     }
 }
diff --git a/src/Lib/Http/Exceptions/HttpException.php b/src/Lib/Http/Exceptions/HttpException.php
@@ -20,7 +20,7 @@ class HttpException extends \RuntimeException
     private $headers = [];
 
     /**
-     * @param string $statusCode
+     * @param int $statusCode
      * @param string $message
      * @param array $headers
      * @param int $code

diff --git a/src/Lib/Logger/Handler/AsyncRotatingFileHandler.php b/src/Lib/Logger/Handler/AsyncRotatingFileHandler.php
@@ -17,15 +17,15 @@ class AsyncRotatingFileHandler extends AbstractProcessingHandler
     private $logDir;
 
     /**
-     * @param int $logDir
+     * @param string $logDir
      * @param bool|int $level
      * @param bool|true $bubble
      */
     public function __construct($logDir, $level = Logger::DEBUG, $bubble = true)
     {
         $this->logDir = $logDir;
 
-        parent::__construct($level, $bubble);
+        parent::__construct((int)$level, $bubble);
     }
 
     /**
@@ -35,13 +35,13 @@ public function __construct($logDir, $level = Logger::DEBUG, $bubble = true)
      */
     protected function write(array $record)
     {
-        if (! is_dir($this->logDir)) {
+        if (!is_dir($this->logDir)) {
             $this->createDir();
         }
 
         $filename = $this->logDir . '/' . date('Y-m-d') . '.log';
 
-        swoole_async_write($filename, (string) $record['formatted'], -1);
+        swoole_async_write($filename, (string)$record['formatted'], -1);
     }
 
     /**

diff --git a/src/Lib/Server/Swoole/Server.php b/src/Lib/Server/Swoole/Server.php
@@ -11,15 +11,14 @@
  */
 class Server implements ServerInterface
 {
-    /**
-     * @var ContainerInterface
-     */
-    private $app;
-
     /**
      * @var \swoole_http_server
      */
     public $server;
+    /**
+     * @var ContainerInterface
+     */
+    private $app;
 
     /**
      * @param ContainerInterface $app

diff --git a/src/Middlewares/RoutingMiddleware.php b/src/Middlewares/RoutingMiddleware.php
@@ -10,12 +10,12 @@
 use Vinnige\Contracts\ClassBasedRoutingHandlerInterface;
 use Vinnige\Contracts\ContainerInterface;
 use Vinnige\Contracts\MiddlewareInterface;
-use Vinnige\Lib\Http\Exceptions\InternalErrorHttpException;
-use Vinnige\Lib\Http\Exceptions\MethodNotAllowedHttpException;
-use Vinnige\Lib\Http\Exceptions\NotFoundHttpException;
 use Vinnige\Events\BeforeDispatchRouteEvent;
 use Vinnige\Events\BeforeRouteEvent;
 use Vinnige\Events\VinnigeEvents;
+use Vinnige\Lib\Http\Exceptions\InternalErrorHttpException;
+use Vinnige\Lib\Http\Exceptions\MethodNotAllowedHttpException;
+use Vinnige\Lib\Http\Exceptions\NotFoundHttpException;
 
 /**
  * Class RoutingMiddleware
@@ -91,7 +91,7 @@ public function __invoke(ServerRequestInterface $request, ResponseInterface $res
                 } else {
                     $controller = $this->app[$info[1]];
 
-                    if (! $controller instanceof ClassBasedRoutingHandlerInterface) {
+                    if (!$controller instanceof ClassBasedRoutingHandlerInterface) {
                         throw new InternalErrorHttpException(
                             sprintf('class %s must implement %s', $info[1], ClassBasedRoutingHandlerInterface::class)
                         );

diff --git a/src/Providers/KernelServiceProvider.php b/src/Providers/KernelServiceProvider.php
@@ -2,16 +2,16 @@
 
 namespace Vinnige\Providers;
 
+use PHPixie\HTTP;
 use PHPixie\Slice;
+use Psr\Http\Message\ResponseInterface;
+use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Message\StreamInterface;
+use Symfony\Component\EventDispatcher\EventDispatcher;
+use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Vinnige\Contracts\ContainerInterface;
 use Vinnige\Contracts\EventSubscriberInterface;
 use Vinnige\Contracts\ServiceProviderInterface;
-use PHPixie\HTTP;
-use Psr\Http\Message\ResponseInterface;
-use Psr\Http\Message\ServerRequestInterface;
-use Symfony\Component\EventDispatcher\EventDispatcherInterface;
-use Symfony\Component\EventDispatcher\EventDispatcher;
 
 /**
  * Class KernelServiceProvider
@@ -86,7 +86,7 @@ function () {
                 $class,
                 function () use ($class, $args) {
                     $stream = (new \ReflectionClass($class))->newInstance($args);
-                    if (! $stream instanceof StreamInterface) {
+                    if (!$stream instanceof StreamInterface) {
                         throw new \RuntimeException(
                             sprintf('Http response stream must be instance of %s', StreamInterface::class)
                         );

diff --git a/src/Providers/MiddlewareDispatcherServiceProvider.php b/src/Providers/MiddlewareDispatcherServiceProvider.php
@@ -2,11 +2,10 @@
 
 namespace Vinnige\Providers;
 
-use Vinnige\Application;
+use Relay\RelayBuilder;
 use Vinnige\Contracts\ContainerInterface;
 use Vinnige\Contracts\MiddlewareInterface;
 use Vinnige\Contracts\ServiceProviderInterface;
-use Relay\RelayBuilder;
 
 /**
  * Class MiddlewareDispatcherServiceProvider
@@ -56,7 +55,7 @@ public function middlewareResolver($class)
 
         $concrete = $this->app[$class];
 
-        if (! $concrete instanceof MiddlewareInterface) {
+        if (!$concrete instanceof MiddlewareInterface) {
             $message = printf('middleware %s must be instance of %s', $class, MiddlewareInterface::class);
 
             // TODO: log this error

diff --git a/src/Providers/MonologServiceProvider.php b/src/Providers/MonologServiceProvider.php
@@ -4,10 +4,10 @@
 
 use Monolog\Formatter\FormatterInterface;
 use Monolog\Handler\HandlerInterface;
+use Monolog\Logger;
 use Psr\Log\InvalidArgumentException;
 use Vinnige\Contracts\ContainerInterface;
 use Vinnige\Contracts\ServiceProviderInterface;
-use Monolog\Logger;
 
 /**
  * Class MonologServiceProvider

diff --git a/src/Providers/RoutingServiceProvider.php b/src/Providers/RoutingServiceProvider.php
@@ -2,13 +2,12 @@
 
 namespace Vinnige\Providers;
 
-use FastRoute\RouteParser\Std as RouteParser;
-use FastRoute\RouteParser as RouteParserInterface;
-use FastRoute\DataGenerator\GroupCountBased as DataGenerator;
 use FastRoute\DataGenerator as DataGeneratorInterface;
-use FastRoute\RouteCollector;
+use FastRoute\DataGenerator\GroupCountBased as DataGenerator;
 use FastRoute\Dispatcher\GroupCountBased as RouteDispatcher;
-use Vinnige\Application;
+use FastRoute\RouteCollector;
+use FastRoute\RouteParser as RouteParserInterface;
+use FastRoute\RouteParser\Std as RouteParser;
 use Vinnige\Contracts\ContainerInterface;
 use Vinnige\Contracts\ServiceProviderInterface;
 

diff --git a/src/Providers/SwooleServerServiceProvider.php b/src/Providers/SwooleServerServiceProvider.php
@@ -3,10 +3,10 @@
 namespace Vinnige\Providers;
 
 use Vinnige\Contracts\ContainerInterface;
-use Vinnige\Contracts\ServiceProviderInterface;
 use Vinnige\Contracts\ServerInterface;
 use Vinnige\Contracts\ServerRequestHandlerInterface;
 use Vinnige\Contracts\ServerResponderInterface;
+use Vinnige\Contracts\ServiceProviderInterface;
 use Vinnige\Lib\Server\Swoole\Server;
 use Vinnige\Lib\Server\Swoole\ServerRequestHandler;
 use Vinnige\Lib\Server\Swoole\ServerResponder;