Deps fix #19
Merged
Deps fix #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| "webpack-cli": "^3.2.1" | ||
| }, | ||
| "lint-staged": { | ||
| "src/**/*.js": [ |
There was a problem hiding this comment.
you can use {src,test}/**/*.js
also prettier --write should be enough
There was a problem hiding this comment.
@ForsakenHarmony i had to re-open these because tests have fixtures/**/*.js and i din't knwo a good way of excluding them in this single statement
There was a problem hiding this comment.
There was a problem hiding this comment.
gotcha thanks :), u da best
| "ava": "^1.0.1", | ||
| "deepcopy": "^1.0.0", | ||
| "webpack": "^4.28.4" | ||
| "chalk": "^2.4.1", |
There was a problem hiding this comment.
oh yes probably in next PR then
ForsakenHarmony
approved these changes
Jun 7, 2019
|
Oh I'm so sorry, I completely missed the notification for this as well as you asking me for a PR 😥 |
|
package.json looks good though 👍 thanks for the quick fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16
@jgierer12 can you please review
package.json?