Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preact X support? #10

Open
rosenbjerg opened this issue Jan 15, 2020 · 3 comments
Open

Preact X support? #10

rosenbjerg opened this issue Jan 15, 2020 · 3 comments

Comments

@rosenbjerg
Copy link

rosenbjerg commented Jan 15, 2020

I am having problems using liquid-route with project upgraded from Preact 8 to Preact X;

When visiting /login, nothing is rendered with this:
<LiquidRoute animator={PopAnimation} path="/login" component={Login}/>
but changing it to not use liquid-route, like this, works:
Route path="/login" component={Login} /> or <Login path="/login"/>

liquid-route worked perfectly in Preact 8, but not in Preact X.
I have seen that you have deprecated AsyncRoute, so what is the fate of LiquidRoute?

@rosenbjerg
Copy link
Author

rosenbjerg commented Jan 15, 2020

I have seen that Preact X has lazy but I am unsure how that replaces LiquidRoute. And I like the animations

@prateekbh
Copy link
Owner

Great question. Off late I have not had a chance to take a look at this.
I can try to take a look at this soon

@rosenbjerg
Copy link
Author

That sounds great.
I hope there is a practical way to support Preact X, as I really think the animations liquid-route provides is a great (and easy) addition to most Preact apps :)

Perhaps Suspense and lazy could be used for Preact X support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants