Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version 1.0.0 #53

Merged
merged 27 commits into from Feb 7, 2022
Merged

version 1.0.0 #53

merged 27 commits into from Feb 7, 2022

Conversation

prateekmedia
Copy link
Member

@prateekmedia prateekmedia commented Jan 20, 2022 •
edited

BREAKING

  • AdwHeaderBar.minimal is now AdwHeaderBar.custom
  • Remove label parameter from AdwTextField

Changes to widgets

HeaderBar

  • Now the AdwHeaderBar is not dependent on any package, windowDecor object is now optional
  • Add isTransparent parameter => Makes AdwHeaderBar's background and border color

Popover

ViewSwitcher

  • Add badge in AdwViewSwitcher

New Widgets

  • AdwSwitch => port of GtkSwitch from gtk4
  • AdwAboutWindow => port of upcoming AdwAboutWindow from libadwaita

@prateekmedia prateekmedia requested review from simrat39, jesusrp98 and MalcolmMielle and removed request for simrat39 and jesusrp98 January 23, 2022 19:00
@MalcolmMielle
Copy link
Collaborator

I'll have a look as soon as I can :)

simrat39
simrat39 requested changes Jan 24, 2022
View reviewed changes
lib/src/widgets/adw/header_bar.dart Outdated Show resolved Hide resolved
lib/src/widgets/window_buttons/close.dart Outdated Show resolved Hide resolved
lib/src/widgets/window_buttons/maximize.dart Outdated Show resolved Hide resolved
lib/src/widgets/window_buttons/minimize.dart Outdated Show resolved Hide resolved
@prateekmedia
Break some stuff by renaming minimal to custom in HeaderBar
9b5fe05 
Don't require window_decorations package
Use Custom Painter for rendering window buttons, add minimize btn
@prateekmedia prateekmedia changed the title Default libadwaita's header buttons feat(headerbar): update header buttons Jan 24, 2022
@prateekmedia prateekmedia marked this pull request as ready for review January 27, 2022 11:21
@prateekmedia prateekmedia changed the title feat(headerbar): update header buttons A Big Update Jan 29, 2022
@prateekmedia prateekmedia changed the title A Big Update version 1.0.0 Jan 29, 2022
MalcolmMielle
MalcolmMielle requested changes Jan 29, 2022
View reviewed changes
Copy link
Collaborator

@MalcolmMielle MalcolmMielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I don't have more time to go through the code right now :S. I didn't have time to run the code itself.

Great work! A lot of good stuff in this commit and a lot of very needed addition to the package :D!
I've added some comments, mainly cosmetic, comments, and some about the logic.

Thanks a again for the great PR!

lib/src/widgets/widgets.dart Show resolved Hide resolved
lib/src/widgets/gtk/popup_menu.dart Outdated Show resolved Hide resolved
pubspec.yaml Show resolved Hide resolved
lib/src/widgets/adw/new/window_button_builder.dart Outdated Show resolved Hide resolved
lib/src/widgets/adw/new/window_button_builder.dart Outdated Show resolved Hide resolved
lib/src/widgets/adw/combo_row.dart Outdated Show resolved Hide resolved
lib/src/widgets/adw/header_bar.dart Outdated Show resolved Hide resolved
lib/src/widgets/adw/switch.dart Outdated Show resolved Hide resolved
lib/src/widgets/adw/switch.dart Outdated Show resolved Hide resolved
lib/src/widgets/adw/switch.dart Show resolved Hide resolved
@prateekmedia
Copy link
Member Author

I think it is ready to merge, I will ask for a final review if any and then it will be merged this week or so.

@pablojimpas
Copy link
Contributor

I think it is ready to merge, I will ask for a final review if any and then it will be merged this week or so.

I suggest we should hold the 1.0.0 release until we find a right solution to issue #46

I haven't looked for ways to fix it but I think it's worth fixing this before a "stable" release, because a) it's bad API design and b) users of this package may expect some stability and not a lot of breaking changes in AdwSidebar which is probably one of the most essential & common widgets. There's no need to rush a release.

@MalcolmMielle
Copy link
Collaborator

While I agree with @pablojimpas that fixing #46 should come before stable release if possible, I think this PR should be merged when done and the fix to #46 should be in a different PR. It'll make it easier to review.

@prateekmedia
Copy link
Member Author

I am soon going to create another PR to fix #46 before stable release.

@prateekmedia prateekmedia merged commit 66dc9fb into main Feb 7, 2022
@prateekmedia
Copy link
Member Author

prateekmedia commented Feb 7, 2022 •
edited

PR for fixing #46 is #56

@prateekmedia prateekmedia deleted the add_window_buttons branch February 7, 2022 15:55
@pablojimpas
Copy link
Contributor

PR for fixing #46 is #56

Good to hear that! Maybe you can use some insight from @jesusrp98 since I think he did some research on this topic

@prateekmedia
Copy link
Member Author

@pablojimpas Hmm, he didn't posted anything after that so maybe he got busy, Idk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablojimpas pablojimpas pablojimpas left review comments

@jesusrp98 jesusrp98 Awaiting requested review from jesusrp98

@simrat39 simrat39 Awaiting requested review from simrat39

@MalcolmMielle MalcolmMielle Awaiting requested review from MalcolmMielle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prateekmedia @MalcolmMielle @pablojimpas @simrat39