Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Converter App using python #709

Merged

Conversation

chandu6111
Copy link
Contributor

Related Issue

  • Info about the related issue
    Title: Document Converter App using Python
    Name: Chandana (chandu6111)
    Label: Feature Request
  • LGM-SOC'21 Participant
  • Contributor

Closes: #513

Changes I've made

  • Added a folder Document Converter App under the Basic Python Scripts folder.
  • The folder contains 8 files which consist of the code scripts of 8 different types of conversions along with comments on each line.
  • It also has a Readme.MD file and requirements.txt file which explains everything about the code.
  • It has a folder named Demo Videos which contains output videos.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

@chandu6111
Copy link
Contributor Author

@prathimacode-hub please do review my PR and lemme know the changes required :)

@prathimacode-hub prathimacode-hub added LGMSOC21 This issue will be considered for LGM-SOC 21 To Do Update Pending labels Jul 11, 2021
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no code in pdf to ppt, ppt to pdf. Also README should be elaborate. Follow the template given. @chandu6111

@chandu6111
Copy link
Contributor Author

There is no code in pdf to ppt, ppt to pdf. Also, README should be elaborate. Follow the template given. @chandu6111

@prathimacode-hub for pdf to ppt and ppt to pdf you can directly execute the commands (given in the comments) in the terminal. That's why I didn't write code, I just wrote the commands in comments. You don't need a code for that, after installing the requirements, if you execute the command given in comments of ppt_to_pdf and pdf_to_ppt in the terminal, they directly get converted. Tell me if this is Okay for you, because I didn't find the other way for these 2 conversions.

I will check the Readme template once.

@Debashish-hub
Copy link
Collaborator

There is no code in pdf to ppt, ppt to pdf. Also, README should be elaborate. Follow the template given. @chandu6111

@prathimacode-hub for pdf to ppt and ppt to pdf you can directly execute the commands (given in the comments) in the terminal. That's why I didn't write code, I just wrote the commands in comments. You don't need a code for that, after installing the requirements, if you execute the command given in comments of ppt_to_pdf and pdf_to_ppt in the terminal, they directly get converted. Tell me if this is Okay for you, because I didn't find the other way for these 2 conversions.

I will check the Readme template once.

There is no code in pdf to ppt, ppt to pdf. Also, README should be elaborate. Follow the template given. @chandu6111

@prathimacode-hub for pdf to ppt and ppt to pdf you can directly execute the commands (given in the comments) in the terminal. That's why I didn't write code, I just wrote the commands in comments. You don't need a code for that, after installing the requirements, if you execute the command given in comments of ppt_to_pdf and pdf_to_ppt in the terminal, they directly get converted. Tell me if this is Okay for you, because I didn't find the other way for these 2 conversions.

I will check the Readme template once.

Doesn't it require the name of file or path of file to be converted?

You can add all the steps with comments in that file and the required code

@chandu6111
Copy link
Contributor Author

The path of the file should be mentioned in the command executed in the terminal itself. Could you please watch the demo video under

  • Demo Videos >
  • ppt_to_pdf.mp4 and pdf_to_ppt.mp4

You will get a clear idea of how it works
@Debashish-hub and @prathimacode-hub

@Debashish-hub
Copy link
Collaborator

The path of the file should be mentioned in the command executed in the terminal itself. Could you please watch the demo video under

  • Demo Videos >
  • ppt_to_pdf.mp4 and pdf_to_ppt.mp4

You will get a clear idea of how it works
@Debashish-hub and @prathimacode-hub

You just add all the details that you are doing in the file.

@prathimacode-hub
Copy link
Owner

Have you done the changes? @chandu6111

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md needs more details, since you had done multiple conversions. It should show all the things you had done and also check on with README template given if you had missed up anything. @chandu6111

@chandu6111
Copy link
Contributor Author

So, I have removed those 2 files and added the commands in the Readme itself. Once please review the changes @prathimacode-hub

And I made some more changes in Readme including links for particular code files. It is descriptive now...

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab and outstanding work. PR approved. Keep rocking. Good to see your initiation to do all the conversions. 🤩🙌👏@chandu6111

@prathimacode-hub prathimacode-hub added the 🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21 & DCP21. label Jul 15, 2021
@prathimacode-hub prathimacode-hub merged commit 23edc82 into prathimacode-hub:main Jul 15, 2021
@prathimacode-hub prathimacode-hub removed the To Do Update Pending label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21 & DCP21. LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Converter App
3 participants