New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Converter App using python #709
Document Converter App using python #709
Conversation
@prathimacode-hub please do review my PR and lemme know the changes required :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no code in pdf to ppt, ppt to pdf. Also README should be elaborate. Follow the template given. @chandu6111
@prathimacode-hub for pdf to ppt and ppt to pdf you can directly execute the commands (given in the comments) in the terminal. That's why I didn't write code, I just wrote the commands in comments. You don't need a code for that, after installing the requirements, if you execute the command given in comments of ppt_to_pdf and pdf_to_ppt in the terminal, they directly get converted. Tell me if this is Okay for you, because I didn't find the other way for these 2 conversions. I will check the Readme template once. |
Doesn't it require the name of file or path of file to be converted? You can add all the steps with comments in that file and the required code |
The path of the file should be mentioned in the command executed in the terminal itself. Could you please watch the demo video under
You will get a clear idea of how it works |
You just add all the details that you are doing in the file. |
Have you done the changes? @chandu6111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md needs more details, since you had done multiple conversions. It should show all the things you had done and also check on with README template given if you had missed up anything. @chandu6111
So, I have removed those 2 files and added the commands in the Readme itself. Once please review the changes @prathimacode-hub And I made some more changes in Readme including links for particular code files. It is descriptive now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fab and outstanding work. PR approved. Keep rocking. Good to see your initiation to do all the conversions. 🤩🙌👏@chandu6111
Related Issue
Title: Document Converter App using Python
Name: Chandana (chandu6111)
Label: Feature Request
Closes: #513
Changes I've made
Type of change
What sort of change have you made:
Checklist: