Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner login screen #59

Merged
merged 4 commits into from Mar 27, 2021
Merged

Conversation

rakshitkamboj
Copy link
Contributor

I have successfully added a spinner in login_Screen that will show up after clicking on LoginButton and will hide when user will navigate to homeScreen and also if any error occurred during the process it will hide itself.

@rakshitkamboj
Copy link
Contributor Author

@pratyushmp Can you please review this PR.

@pratyushmp
Copy link
Owner

Attach a video of the changes you have made.

@rakshitkamboj
Copy link
Contributor Author

@pratyushmp Here it is.

Spinner.mp4

@pratyushmp
Copy link
Owner

pratyushmp commented Mar 27, 2021

@rakshitkamboj There are merge conflicts in your PR, please resolve them

@rakshitkamboj
Copy link
Contributor Author

@pratyushmp Can you please help me in solving the conflicts.
This is my first time having these type of conflicts.
Can you please guide me in solving these ?

@pratyushmp
Copy link
Owner

@rakshitkamboj make sure that the branch from which you creating a PR is up to date with the main repository of Batua.

@infiniteoverflow
Copy link
Collaborator

@rakshitkamboj You need to make sure that your branch is even with the main branch. For that do the following :

git remote add upstream 'https://github.com/pratyushmp/Batua'

git fetch upstream

git pull upstream main

git push origin <your-branch-name>

Enter these 4 commands in ur terminal and this will even ur branch...that should fix this.

If this dosent work , we will find some other alternatives

@rakshitkamboj
Copy link
Contributor Author

@infiniteoverflow @pratyushmp Thanks a lot for helping.
Now I think it have no conflicts in it .
Please check it now.

@pratyushmp pratyushmp merged commit 3adb128 into pratyushmp:main Mar 27, 2021
@pratyushmp pratyushmp linked an issue Mar 27, 2021 that may be closed by this pull request
@pratyushmp
Copy link
Owner

@rakshitkamboj Good Job!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Spinner in Login_Screen
3 participants