-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spinner login screen #59
Spinner login screen #59
Conversation
@pratyushmp Can you please review this PR. |
Attach a video of the changes you have made. |
@pratyushmp Here it is. Spinner.mp4 |
@rakshitkamboj There are merge conflicts in your PR, please resolve them |
@pratyushmp Can you please help me in solving the conflicts. |
@rakshitkamboj make sure that the branch from which you creating a PR is up to date with the main repository of Batua. |
@rakshitkamboj You need to make sure that your branch is even with the main branch. For that do the following : git remote add upstream 'https://github.com/pratyushmp/Batua'
git fetch upstream
git pull upstream main
git push origin <your-branch-name> Enter these 4 commands in ur terminal and this will even ur branch...that should fix this. If this dosent work , we will find some other alternatives |
@infiniteoverflow @pratyushmp Thanks a lot for helping. |
@rakshitkamboj Good Job!! |
I have successfully added a spinner in login_Screen that will show up after clicking on LoginButton and will hide when user will navigate to homeScreen and also if any error occurred during the process it will hide itself.