Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #82 #83

Merged
merged 1 commit into from
May 9, 2021
Merged

Fixes #82 #83

merged 1 commit into from
May 9, 2021

Conversation

SapinderSingh
Copy link
Contributor

Description :

Now icons change color, when selected and unselected.

Fixes #82

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change :

  • Bug fix (non-breaking change which fixes an issue)

Checklist :

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.
    ezgif com-gif-maker (2)

@pratyushmp
Copy link
Owner

@SapinderSingh Why does it show null? Just show the profile screen for the third icon in the bottom nav bar.

@SapinderSingh
Copy link
Contributor Author

But I haven't made any changes to profile screen.

@pratyushmp pratyushmp merged commit 6899dc3 into pratyushmp:main May 9, 2021
@SapinderSingh SapinderSingh deleted the issue-82 branch May 9, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SapinderSingh SapinderSingh

Labels
GSSOC21 Level1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bottom Navigation Bar behavior.
2 participants
@SapinderSingh @pratyushmp