Further develop the data-search-children functionality
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at improving the features added in this commit.
The initial implementation worked by indexing only the immediate children of the element that had the
data-search-childrenattribute. This PR builds on top of that behavior, and now indexes all heading elements under that element with the attribute, not mattering if they are direct or indirect children (E.g. children/grandchildren).Alongside the code that handles the main purpose of this PR, this PR contains:
README.mdupdates.README.mdtable..prettierrcfile to enforce more consistent styling across development environments.html-to-doc.jsfile, more specifically, a refactor of thegetSectionHeadersfunction.html-to-doc.jsfile.