Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Index html file when multiple article elements present in file #145

Merged
merged 1 commit into from May 8, 2024

Conversation

mcintyre-ionic
Copy link
Contributor

I think this may resolve issues #126 and #134.

We observed the same behavior with imports discussed in #126. In our case, the issue was caused by the imports creating additional article elements in the compiled html files. We found during indexing, that workers search through the html files to find the first article element in each file and indexes the article element if it has an element associated with the markdown class. So markdown pages with imports could be skipped during indexing as the article element with the markdown class is not guaranteed to be the first article element in the compiled html file.

This PR allows the workers to search through all articles in each html file to find the article associated the markdown class.

@mcintyre-ionic mcintyre-ionic changed the title Find markdown across multiple articles in same html file Fix: Index html file when multiple article elements present in file Apr 24, 2024
@praveenn77 praveenn77 merged commit 46bccbd into praveenn77:main May 8, 2024
@praveenn77
Copy link
Owner

Thanks for the PR, new version 3.4.0 is published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants