Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop a unit test for FlinkPravegaWriter #67

Closed
EronWright opened this issue Nov 15, 2017 · 0 comments
Closed

Develop a unit test for FlinkPravegaWriter #67

EronWright opened this issue Nov 15, 2017 · 0 comments
Assignees
@EronWright

Comments

@EronWright
Copy link
Contributor

EronWright commented Nov 15, 2017 •
edited
Loading

Problem description
The FlinkPravegaWriter has a pair of existing tests, FlinkPravegaWriterTest and FlinkExactlyOncePravegaWriterTest, that are best understood as integration tests. Overall coverage is low.

Suggestions for an improvement

  • Develop a unit test that uses a mock Pravega event writer to fully exercise the FlinkPravegaWriter.
  • Consolidate the existing tests into a test called FlinkPravegaWriterITCase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EronWright EronWright

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EronWright