Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop a unit test for FlinkPravegaReader #68

Closed
EronWright opened this issue Nov 15, 2017 · 4 comments
Closed

Develop a unit test for FlinkPravegaReader #68

EronWright opened this issue Nov 15, 2017 · 4 comments
Assignees
@tzulitai

Comments

@EronWright
Copy link
Contributor

Problem description
The FlinkPravegaReader has a test FlinkPravegaReaderTest that is best understood as an integration test. Coverage is too low.

Suggestions for an improvement

  • Rename FlinkPravegaReader to FlinkPravegaReaderITCase.
  • Develop a unit test that uses a mock Pravega EventStreamReader.
@tzulitai
Copy link
Contributor

@EronWright, I would gladly take this issue.

Also, I assume that this together with #67 should subsume #51?

@tzulitai tzulitai mentioned this issue Nov 30, 2017
Closed
@EronWright
Copy link
Contributor Author

@tzulitai sounds great, would you mind following the style seen in #76 ?

@tzulitai
Copy link
Contributor

tzulitai commented Dec 7, 2017

Sure, no problem 👌

@tzulitai tzulitai self-assigned this Dec 7, 2017
@EronWright EronWright mentioned this issue Apr 28, 2018
Merged
@EronWright
Copy link
Contributor Author

This is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzulitai tzulitai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EronWright @tzulitai