[Issue-491] Wrong count number of the artifact #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhongle.wang <zhongle_wang@dell.com>
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
============================================
+ Coverage 83.81% 84.06% +0.25%
- Complexity 422 424 +2
============================================
Files 35 35
Lines 1946 1946
Branches 206 206
============================================
+ Hits 1631 1636 +5
+ Misses 170 167 -3
+ Partials 145 143 -2
Continue to review full report at Codecov.
|
crazyzhou
pushed a commit
that referenced
this pull request
Apr 22, 2021
Signed-off-by: zhongle.wang <zhongle_wang@dell.com>
crazyzhou
pushed a commit
that referenced
this pull request
Apr 22, 2021
Signed-off-by: zhongle.wang <zhongle_wang@dell.com>
This was referenced Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhongle.wang zhongle_wang@dell.com
Change log description
A typical name of the artiface should be something like 0.10.0-1.ff9f6d1-SNAPSHOT. With the [version]-[commit count]-[commit sha]-SNAPSHOT format. But for artifacts produced by Github Actions, the commit count are always set to 1. This is caused by the
depth==1clone, so we change it to unlimited.Purpose of the change
Fixes #491
What the code does
Add a parameter to specify the clone depth to be unlimited.
How to verify it
Artifacts build by the new yaml should have the corret commit count.
See the
List of artifactssection of this run.