Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of python code from rust repo #463

Merged

Conversation

AnkurAnand11
Copy link
Contributor

@AnkurAnand11 AnkurAnand11 commented Dec 4, 2023

Change log description
Since we already have a dedicated repo for python client (https://github.com/pravega/pravega-client-python/) , we need to remove all the code related to python from rust repo.

Purpose of the change
Closes #464

What the code does
Remove all the code related to python from rust repo

How to verify it
all test cases should pass.

Signed-off-by: Ankur_Anand <Ankur.Anand@dell.com>
Signed-off-by: Ankur_Anand <Ankur.Anand@dell.com>
@codecov-commenter
Copy link

Codecov Report

Merging #463 (73512a0) into master (c0f1813) will decrease coverage by 0.21%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
- Coverage   72.78%   72.58%   -0.21%     
==========================================
  Files          49       49              
  Lines       12390    12386       -4     
  Branches    12390    12386       -4     
==========================================
- Hits         9018     8990      -28     
- Misses       3372     3396      +24     

see 12 files with indirect coverage changes

@AnkurAnand11 AnkurAnand11 changed the title removal of python code from rust repo Removal of python code from rust repo Dec 6, 2023
@AnkurAnand11 AnkurAnand11 marked this pull request as ready for review December 6, 2023 11:20
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkaitchuck tkaitchuck merged commit 9a04e4e into pravega:master Dec 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Python related code from the Rust repository
4 participants