Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SLTS) - Possible failure during deletion of metadata keys can cause version mismatch in next attempt. #5456

Closed
sachin-j-joshi opened this issue Jan 4, 2021 · 0 comments · Fixed by #5457
Assignees
Labels
area/lts kind/bug Correctness issue

Comments

@sachin-j-joshi
Copy link
Contributor

Problem description
Currently table store has a severe limitation that it can not update and delete keys in the same transaction.
The current work around for this problem is implemented in two steps in TableBasedMetadataStore.writeAll method.
It involves first marking the keys as deleted by updating in first transaction and immediately deleting them.
This works fine as long as both steps succeed, however when second step fails then the whole transaction is aborted. Leaving behind update keys with new version which do not match expected version when new transaction with same keys is reattempted.

Problem location
TableBasedMetadataStore.writeAll

Suggestions for an improvement
Do not fail transaction if keys are successfully marked as deleted even though deleting them failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lts kind/bug Correctness issue
Projects
None yet
1 participant