Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SegmentAggregator should ignore already deleted segments #5994

Closed
andreipaduroiu opened this issue May 5, 2021 · 0 comments · Fixed by #5995
Closed

SegmentAggregator should ignore already deleted segments #5994

andreipaduroiu opened this issue May 5, 2021 · 0 comments · Fixed by #5995
Assignees
@andreipaduroiu
Labels
area/segmentstore kind/enhancement Improvements that should be made version/0.10.0

Comments

@andreipaduroiu
Copy link
Member

Is your feature request related to a problem? Please describe.
If SegmentMetadata.isDeleted, then SegmentAggregator.initialize should attempt to delete the segment from LTS and do nothing more.
@andreipaduroiu andreipaduroiu self-assigned this May 5, 2021
@andreipaduroiu andreipaduroiu mentioned this issue May 5, 2021
Merged
This was referenced May 5, 2021
Closed
Merged
sachin-j-joshi pushed a commit that referenced this issue May 6, 2021
@andreipaduroiu
Issue 5996: Cherry-pick #5994 to r0.9 (#5997)
1eb8e3a 
Issue 5996: Cherry-pick #5994 to r0.9
* Issue 5994: (SegmentStore) Auto-deleting LTS segments if marked as deleted in metadata

Signed-off-by: Andrei Paduroiu <andrei.paduroiu@emc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreipaduroiu andreipaduroiu

Labels
area/segmentstore kind/enhancement Improvements that should be made version/0.10.0
Projects
None yet
Milestone
No milestone
1 participant
@andreipaduroiu