Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary segment container restarts due to Bookkeeper client re-creation mechanism #6772

Closed
RaulGracia opened this issue Jun 10, 2022 · 1 comment · Fixed by #6773
Closed

Unnecessary segment container restarts due to Bookkeeper client re-creation mechanism #6772

RaulGracia opened this issue Jun 10, 2022 · 1 comment · Fixed by #6773
Assignees
@RaulGracia
Labels
area/bookkeeper area/segmentstore area/tier1 kind/enhancement Improvements that should be made priority/P2 version/0.13.0

Comments

@RaulGracia
Copy link
Contributor

Describe the bug
To fix issue #5317, we introduced a Bookkeeper client re-creation mechanism. In parallel, we contributed a PR to Bookkeeper client fixing the actual problem: apache/bookkeeper#2482. The previous PR is included in Bookkeeper 4.15 release, so we can remove that Bookkeeper client re-creation mechanism from Pravega 0.12 onwards.

To Reproduce
n/a

Screenshots
n/a

Additional information
Revert PR #5317, as it is not necessary anymore assuming Bookkeeper >=4.15.
@RaulGracia RaulGracia self-assigned this Jun 10, 2022
@RaulGracia RaulGracia changed the title Unnecessary segment container restarts due to Bookkeeper client closing mechanism Unnecessary segment container restarts due to Bookkeeper client re-creation mechanism Jun 10, 2022
@RaulGracia RaulGracia mentioned this issue Jun 21, 2022
Merged
@RaulGracia
Copy link
Contributor Author

Closed via #6773.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaulGracia RaulGracia

Labels
area/bookkeeper area/segmentstore area/tier1 kind/enhancement Improvements that should be made priority/P2 version/0.13.0
Projects
None yet
Milestone
No milestone
1 participant
@RaulGracia