Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3244: Checkstyle fails on JDK11 while using Gradle daemon - needs an absolute path #3245

Merged
merged 1 commit into from Jan 7, 2019

Conversation

eolivelli
Copy link
Contributor

Change log description
The fix is to use an absolute path in order to refer to the suppressions.xml file.

See detailed explanation in #3244

Purpose of the change
Fixes #3244

What the code does
Compute the absolute path during the execution of the build configuration script and do not rely on relative paths

How to verify it
run this command without errors
JAVA_HOME=/path/to/jdk11 ./gradlew checkstyleMain checkstyleTest

…ds an absolute path

The fix is to use an absolute path in order to refer to the suppressions.xml file

Fixes pravega#3244

Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
@eolivelli
Copy link
Contributor Author

@tkaitchuck @fpj @shrids
this is the second part of the JDK11 support

@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #3245 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3245      +/-   ##
============================================
- Coverage     78.87%   78.81%   -0.06%     
+ Complexity     7986     7979       -7     
============================================
  Files           608      608              
  Lines         31349    31349              
  Branches       3011     3011              
============================================
- Hits          24725    24709      -16     
- Misses         4859     4869      +10     
- Partials       1765     1771       +6
Impacted Files Coverage Δ Complexity Δ
...server/attributes/ContainerAttributeIndexImpl.java 79.71% <0%> (-10.15%) 17% <0%> (-2%)
...gmentstore/server/writer/StorageWriterFactory.java 92.5% <0%> (-5%) 2% <0%> (ø)
...eventProcessor/requesthandlers/SealStreamTask.java 90.9% <0%> (-3.64%) 23% <0%> (-1%)
...tore/server/reading/RedirectedReadResultEntry.java 85.24% <0%> (-3.28%) 24% <0%> (-2%)
...ga/controller/store/client/StoreClientFactory.java 79.59% <0%> (-2.05%) 10% <0%> (-1%)
...ient/segment/impl/AsyncSegmentInputStreamImpl.java 74.13% <0%> (-1.73%) 20% <0%> (-1%)
...a/io/pravega/segmentstore/server/CacheManager.java 79.72% <0%> (-1.36%) 35% <0%> (-1%)
...pravega/controller/store/stream/ZKStoreHelper.java 66.66% <0%> (-1.15%) 48% <0%> (ø)
...a/segmentstore/server/logs/OperationProcessor.java 84.75% <0%> (-1.12%) 38% <0%> (-3%)
...o/pravega/client/stream/impl/ReaderGroupState.java 87.77% <0%> (-0.25%) 41% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5759b...ce9958b. Read the comment docs.

@tkaitchuck tkaitchuck merged commit 714fac3 into pravega:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkstyle fails on JDK11 while using Gradle daemon - needs an absolute path
2 participants