Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4209: Bump versions of dependencies #4210

Merged
merged 16 commits into from
Oct 1, 2019
Merged

Issue 4209: Bump versions of dependencies #4210

merged 16 commits into from
Oct 1, 2019

Conversation

tkaitchuck
Copy link
Member

Change log description

  • Update versions of dependencies.

Purpose of the change
Fixes #4209

What the code does
Increases the versions of all of our current dependencies without breaking any code/tests.

How to verify it
We should run all tests against this branch.

Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Copy link
Contributor

@ravisharda ravisharda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR CI Build is failing with compilation error.

build.gradle Outdated Show resolved Hide resolved
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@tkaitchuck tkaitchuck removed their assignment Sep 26, 2019
@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #4210 into master will increase coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4210      +/-   ##
============================================
+ Coverage     81.67%   81.74%   +0.07%     
- Complexity    10103    10114      +11     
============================================
  Files           672      672              
  Lines         37815    37813       -2     
  Branches       3667     3667              
============================================
+ Hits          30884    30910      +26     
+ Misses         4845     4830      -15     
+ Partials       2086     2073      -13
Impacted Files Coverage Δ Complexity Δ
...avega/segmentstore/server/host/ServiceStarter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/io/pravega/controller/metrics/StreamMetrics.java 73.21% <0%> (-5.36%) 10% <0%> (-1%)
.../server/attributes/SegmentAttributeBTreeIndex.java 89.03% <0%> (-1%) 74% <0%> (-2%)
...pravega/controller/store/stream/ZKStoreHelper.java 75% <0%> (-0.84%) 69% <0%> (ø)
...o/pravega/controller/server/ControllerService.java 80.3% <0%> (-0.78%) 70% <0%> (-1%)
...ntstore/storage/impl/bookkeeper/BookKeeperLog.java 80.79% <0%> (-0.29%) 77% <0%> (-1%)
...ga/controller/task/Stream/StreamMetadataTasks.java 86.11% <0%> (ø) 174% <0%> (ø) ⬇️
...o/pravega/segmentstore/server/logs/DurableLog.java 90.95% <0%> (+0.5%) 67% <0%> (+1%) ⬆️
...ver/containers/StreamSegmentContainerMetadata.java 97.45% <0%> (+0.63%) 54% <0%> (+1%) ⬆️
...main/java/io/pravega/storage/hdfs/HDFSStorage.java 74.37% <0%> (+0.71%) 51% <0%> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359cbcc...5bb67e1. Read the comment docs.

Copy link
Contributor

@ravisharda ravisharda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ravisharda ravisharda removed their assignment Sep 27, 2019

// Same as ISO8601DateFormat but serializing milliseconds.
@Override
public StringBuffer format(Date date, StringBuffer toAppendTo, FieldPosition fieldPosition) {
String value = ISO8601Utils.format(date, true);
String value = com.fasterxml.jackson.databind.util.ISO8601Utils.format(date, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we updating generated file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the build fails with a compilation error.
There is no functional change here, this just suppresses the warnings from importing a deprecated class. Which would normally be a warning, but our build is set to treat warnings as errors and fail the build. Originally I just changed that behaviour but based on feedback, it seemed better to not remove that safety net for the sake of preserving one generated file in it's unmodified state.

Once there is an update to the code generator to use non-deprecated code, we should be able to re-generate the file and leave it unmodified.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the constraints in front of us, I'd say that we modify the file and create a separate issue explaining the problem and pointing to the jackson issue. The new issue should also say that once the jackson issue is resolved, we need to upgrade and regenerate the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkaitchuck can you please open an issue for the same.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #4224

Copy link
Contributor

@shiveshr shiveshr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking because we are modifying a generated file. Please revert that file and rest all looks good.

@tkaitchuck
Copy link
Member Author

Coverage is at 0% because changes are in the gradle file, and the service starter which is only used by integration tests. (Which don't count towards the coverage metric)

@fpj fpj merged commit 6cc30ad into master Oct 1, 2019
@tkaitchuck tkaitchuck deleted the bump-versions branch October 1, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump versions of dependencies
4 participants