Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5216: (R0.7.3) Cherry-pick #5207, #5154, #5155 and #5119 into branch r0.7 #5217

Merged
merged 6 commits into from Sep 28, 2020

Conversation

andreipaduroiu
Copy link
Member

Change log description
Cherry-pick #5207, #5154, #5155 and #5119 into branch r0.7.

Purpose of the change
Fixes #5216.

What the code does
Cherrypick.

How to verify it
Build must pass.

andreipaduroiu and others added 6 commits September 24, 2020 12:43
Signed-off-by: Andrei Paduroiu <andrei.paduroiu@emc.com>
Signed-off-by: Andrei Paduroiu <andrei.paduroiu@emc.com>
Signed-off-by: Andrei Paduroiu <andrei.paduroiu@emc.com>
…Index (pravega#5170)

Fixed a concurrency bug in StreamSegmentReadIndex which could allow index summaries to get out of sync, thus causing the Cache Manager to evict more than needed.

Signed-off-by: Andrei Paduroiu <andrei.paduroiu@emc.com>

Co-authored-by: Tom Kaitchuck <tkaitchuck@users.noreply.github.com>
Signed-off-by: Andrei Paduroiu <andrei.paduroiu@emc.com>
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #5217 into r0.7 will increase coverage by 0.01%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##               r0.7    #5217      +/-   ##
============================================
+ Coverage     83.07%   83.08%   +0.01%     
- Complexity    10859    10867       +8     
============================================
  Files           700      700              
  Lines         39721    39729       +8     
  Branches       3968     3969       +1     
============================================
+ Hits          32997    33008      +11     
  Misses         4533     4533              
+ Partials       2191     2188       -3     
Impacted Files Coverage Δ Complexity Δ
...a/io/pravega/segmentstore/server/CacheManager.java 81.77% <0.00%> (-3.65%) 50.00 <0.00> (-1.00)
...ore/server/reading/CompletableReadResultEntry.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...ore/server/reading/StreamSegmentStorageReader.java 67.30% <ø> (ø) 1.00 <0.00> (ø)
.../segmentstore/server/tables/TableBucketReader.java 94.59% <ø> (ø) 23.00 <0.00> (ø)
...tstore/server/reading/StreamSegmentReadResult.java 82.14% <83.33%> (+1.37%) 23.00 <3.00> (+2.00)
...ntstore/server/reading/StreamSegmentReadIndex.java 81.48% <90.47%> (+0.07%) 117.00 <3.00> (+3.00)
.../segmentstore/server/reading/ReadIndexSummary.java 91.66% <100.00%> (+0.36%) 9.00 <2.00> (+1.00)
...gmentstore/server/tables/WriterTableProcessor.java 86.59% <100.00%> (+0.07%) 47.00 <1.00> (ø)
...server/attributes/ContainerAttributeIndexImpl.java 79.10% <0.00%> (-2.99%) 17.00% <0.00%> (-2.00%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b119f66...7834de5. Read the comment docs.

Copy link
Contributor

@sachin-j-joshi sachin-j-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andreipaduroiu andreipaduroiu merged commit eb46495 into pravega:r0.7 Sep 28, 2020
@andreipaduroiu andreipaduroiu deleted the issue-5216-r0.7.3 branch September 28, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants