Issue 5597 : ExtendedS3ChunkStorage and ExtendedS3Storage should close S3Client. #5598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e S3Client. Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
Codecov Report
@@ Coverage Diff @@
## master #5598 +/- ##
============================================
- Coverage 84.69% 84.69% -0.01%
- Complexity 13857 13858 +1
============================================
Files 917 917
Lines 51323 51339 +16
Branches 5297 5299 +2
============================================
+ Hits 43470 43480 +10
- Misses 4960 4962 +2
- Partials 2893 2897 +4 Continue to review full report at Codecov.
|
andreipaduroiu
requested changes
Jan 28, 2021
bindings/src/main/java/io/pravega/storage/extendeds3/ExtendedS3ChunkStorage.java
Outdated
Show resolved
Hide resolved
bindings/src/main/java/io/pravega/storage/extendeds3/ExtendedS3Storage.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
…e-5597-SLTS-close-S3-Client
|
@andreipaduroiu Changed the constructor to take Also we want to move towards optimistic checks. So, instead of checking isClosed on every call we just let the calls fail when client is closed. |
andreipaduroiu
approved these changes
Feb 1, 2021
Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
…sachin-j-joshi/pravega into issue-5597-SLTS-close-S3-Client
tkaitchuck
pushed a commit
to tkaitchuck/pravega-1
that referenced
this pull request
Feb 15, 2021
…e S3Client. (pravega#5598) ExtendedS3ChunkStorage and ExtendedS3Storage should close S3Client. Signed-off-by: Sachin Joshi <sachin.joshi@emc.com> Co-authored-by: Andrei Paduroiu <andreipaduroiu@users.noreply.github.com>
tkaitchuck
pushed a commit
to tkaitchuck/pravega-1
that referenced
this pull request
Feb 15, 2021
…e S3Client. (pravega#5598) ExtendedS3ChunkStorage and ExtendedS3Storage should close S3Client. Signed-off-by: Sachin Joshi <sachin.joshi@emc.com> Co-authored-by: Andrei Paduroiu <andreipaduroiu@users.noreply.github.com> Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
sachin-j-joshi
added a commit
to sachin-j-joshi/pravega
that referenced
this pull request
Feb 23, 2021
…e S3Client. (pravega#5598) ExtendedS3ChunkStorage and ExtendedS3Storage should close S3Client. Signed-off-by: Sachin Joshi <sachin.joshi@emc.com> Co-authored-by: Andrei Paduroiu <andreipaduroiu@users.noreply.github.com>
sachin-j-joshi
added a commit
that referenced
this pull request
Mar 19, 2021
Cherry-picks following changes 0.9 Issue 5518: (SLTS) Fix Integer overflow. (#5520) Issue 5606: BoundedInputStream::markSupported() should always return false.. (#5615) Issue 5597 : ExtendedS3ChunkStorage and ExtendedS3Storage should close S3Client. (#5598) Issue 5535: (SegmentStore) Refactoring ExtendedS3 Test Mocks (#5537) Issue 5456: (SLTS) - Handle possible failure during deletion of metadata keys can cause version mismatch in next attempt (#5457) Issue 5458: (SLTS) For read operation, read all chunks in parallel. (#5459) Issue 4967: (SLTS) Add createWithContent overload that creates object and writes to it in a single call. (#5455) Issue 5664: SLTS - fix possible thread visibility issues.. (#5665) Issue 5475: Eliminate unnecessary pessimistic checks. (#5662) Issue 5570: (SLTS) AsyncBaseChunkStorage latency should not include time spent in waiting to be executed. (#5661) Issue 4967: (SLTS) No need to check last chunk length for claimOwnership for no append mode. (#5663) Issue 5673: (SLTS) Fix wrong GC config (#5674) Issue 5737: (SLTS) Improve metrics (#5746) Issue 5460: (SLTS) Add read index virtual block entries to metadata. (#5461) Issue 5772: (SLTS) - BaseMetadataStore does not evict entries from buffer. (#5773) Issue 5798: (SLTS) Fix close in GarbageCollector, ExtendedS3ChunkStorage and HDFSChunkStorage. (#5800) Issue 5788: (SLTS) Remove ACL operations from ExtendedS3ChunkStorage (#5790) Issue 5808: SLTS - Fix Preconditions checks to include enough information in message. (#5809) Issue 5853: SLTS - BaseMetadataStore.get does not return deep copy when loading from store. #5858 Issue 5866: (SLTS) ReadIndexCache stats not reported. (#5867) Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtendedS3ChunkStorage and ExtendedS3Storage should close S3Client
Signed-off-by: Sachin Joshi sachin.joshi@emc.com
Change log description
ExtendedS3ChunkStorage and ExtendedS3Storage should close S3Client
Purpose of the change
Fixes #5597
What the code does
ChunkedSegmentStorage closes chunkStorage.
ExtendedS3ChunkStorage and ExtendedS3Storage close S3Client.
How to verify it
Build should pass.