Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6620: Make fetching tokens on segment reader creation async #6622

Merged
merged 1 commit into from Mar 7, 2022

Conversation

tkaitchuck
Copy link
Member

Signed-off-by: Tom Kaitchuck tom.kaitchuck@emc.com

Change log description
Make fetching tokens on segment reader creation async

Purpose of the change
Fixes #6620

What the code does
Makes the token fetching upon creation of a new segment reader asynchronous.

Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #6622 (b8f5bd8) into master (136e14e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6622      +/-   ##
============================================
+ Coverage     86.28%   86.31%   +0.03%     
- Complexity    15646    15656      +10     
============================================
  Files          1017     1017              
  Lines         58696    58694       -2     
  Branches       5948     5948              
============================================
+ Hits          50644    50663      +19     
+ Misses         4942     4928      -14     
+ Partials       3110     3103       -7     
Impacted Files Coverage Δ
...a/client/byteStream/impl/ByteStreamClientImpl.java 100.00% <100.00%> (ø)
...nt/segment/impl/SegmentInputStreamFactoryImpl.java 87.50% <100.00%> (-0.74%) ⬇️
...a/segmentstore/server/logs/OperationProcessor.java 88.88% <0.00%> (-1.80%) ⬇️
...tore/server/containers/StreamSegmentContainer.java 89.64% <0.00%> (-0.67%) ⬇️
...main/java/io/pravega/storage/hdfs/HDFSStorage.java 73.33% <0.00%> (+0.31%) ⬆️
.../segmentstore/server/writer/SegmentAggregator.java 80.17% <0.00%> (+0.42%) ⬆️
...ver/containers/StreamSegmentContainerMetadata.java 97.45% <0.00%> (+0.63%) ⬆️
...client/control/impl/ControllerResolverFactory.java 83.80% <0.00%> (+0.95%) ⬆️
.../server/attributes/SegmentAttributeBTreeIndex.java 90.98% <0.00%> (+1.09%) ⬆️
...ga/controller/store/client/StoreClientFactory.java 81.03% <0.00%> (+1.72%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 136e14e...b8f5bd8. Read the comment docs.

Copy link
Contributor

@ShwethaSNayak ShwethaSNayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Async way of fetching delegation token while creating segment reader will definitely improve the performance.

Copy link
Contributor

@sachin-j-joshi sachin-j-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachin-j-joshi sachin-j-joshi merged commit 34e4342 into pravega:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up creation of segment readers with asynchronous token fetch
3 participants