Issue 233: Fixed chart bug and made ready and unready fields as nullable and added checks for various crd fields #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: prabhaker24 <prabhaker.saxena@dell.com>
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 81.81% 81.81%
=======================================
Files 11 11
Lines 1248 1248
=======================================
Hits 1021 1021
Misses 162 162
Partials 65 65
Continue to review full report at Codecov.
|
added 3 commits
August 28, 2020 09:19
Signed-off-by: prabhaker24 <prabhaker.saxena@dell.com>
Signed-off-by: prabhaker24 <prabhaker.saxena@dell.com>
Signed-off-by: prabhaker24 <prabhaker.saxena@dell.com>
anishakj
requested changes
Sep 1, 2020
added 2 commits
September 2, 2020 20:35
Signed-off-by: prabhaker24 <prabhaker.saxena@dell.com>
Signed-off-by: prabhaker24 <prabhaker.saxena@dell.com>
|
Could you please check can we add validations for storagetype and access modes |
Signed-off-by: prabhaker24 <prabhaker.saxena@dell.com>
Prabhaker24
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: prabhaker24 prabhaker.saxena@dell.com
Change log description
Create zookeeper cluster is failing with chart due to domain name not specified correctly in charts Ater the OpenApi SchemaValidation check Added and made the ready and unready member list as nullable in crd.
Purpose of the change
Fixes #233 #208
What the code does
Because of the OpenApiSchemaValidation being present we can't have the domainname with null value which was the case till now so I have changed it so that if no value is provided domainname field get's skipped along with that to keep backwards compatibility that is for the latest operator code to be able to deploy zookeeper cluster 0.2.8 or before we need to make ready and unready member list as nullable in the crd as they were not omitempty before.
Additionally, I have removed controller-gen command from make file and have used operator-sdk command to create the crd below is the command:-
operator-sdk generate crdsAnd have added validation checks for various fields in the crd.
How to verify it
Create zookeeper cluster using charts after deploying the zookeeper-operator, Cluster should get deployed.