Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 241: Chart changes and CRD refactoring #245

Merged
merged 3 commits into from Sep 17, 2020

Conversation

SrishT
Copy link
Contributor

@SrishT SrishT commented Sep 17, 2020

Signed-off-by: SrishT Srishti.Thakkar@dell.com

Change log description

Helm upgrade of the zookeeper operator and zookeeper cluster from 0.2.8 to 0.2.9-rc0 is failing. Also the additionalPrinterColumns from the ZookeeperCluster CRD have been removed.

Purpose of the change

Fixes #241

What the code does

Changes the location of the CRD from the crds/ since that was causing the operator upgrade from 0.2.8 to 0.2.9-rc0 to fail, and adds the additionalPrinterColumns back into the ZookeeperCluster CRD. Also adds default value for the storageType and kubernetesClusterDomain fields so that helm upgrade of the zookeeper cluster using the reuse-values flag does not fail.

How to verify it

  • Helm upgrade of zookeeper operator from 0.2.8 to 0.2.9-rc0 should succeed.
  • Helm upgrade of zookeeper cluster from 0.2.8 0.2.9-rc0 should succeed both with and without the reuse-values flag.

Signed-off-by: SrishT <Srishti.Thakkar@dell.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2020

Codecov Report

Merging #245 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files          11       11           
  Lines        1258     1258           
=======================================
  Hits         1021     1021           
  Misses        170      170           
  Partials       67       67           
Impacted Files Coverage Δ
...g/apis/zookeeper/v1beta1/zookeepercluster_types.go 98.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9a3cf...a295422. Read the comment docs.

Signed-off-by: SrishT <Srishti.Thakkar@dell.com>
@SrishT SrishT marked this pull request as ready for review September 17, 2020 10:49
Signed-off-by: SrishT <Srishti.Thakkar@dell.com>
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Prabhaker24 Prabhaker24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit bccf417 into master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make changes to allow helm upgrades using "reuse-values"
4 participants