Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 363: Fixing CRD to work with k8 1.15 version #370

Merged
merged 1 commit into from Jul 19, 2021

Conversation

amuraru
Copy link
Contributor

@amuraru amuraru commented Jul 19, 2021

Fix issue in CRD

Change log description

Change log description
helm install fails to install the new CRD in k8s 1.15
Fixing by reverting to using helm conditional on these old versions

Purpose of the change

Fixes #363

What the code does

Fixed the CRD

How to verify it

Verified operator and cluster install works fine

…DUM-2 (pravega#369)

Correctly conditionally add protocol in the `kubernetes-list-map-keys:`
@anishakj anishakj changed the title fix issue-314 by checking zookeeperCluster resource version before updating sts ADDENDUM Issue 363: Fixing CRD to work with k8 1.15 version Jul 19, 2021
Copy link
Contributor

@anishakj anishakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishakj anishakj merged commit 5e2c1bb into pravega:master Jul 19, 2021
@amuraru amuraru deleted the 363-add-2 branch July 19, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants